[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig |
Date: |
Thu, 07 Jun 2018 14:22:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Peter Xu <address@hidden> writes:
> On Tue, Jun 05, 2018 at 01:26:34PM +0100, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert" <address@hidden>
>>
>> Allow a bunch of the info commands to be used in preconfig.
>> Could probably add most of them.
>
> I guess some of them may not work yet during preconfig. E.g.:
>
> $ ./x86_64-softmmu/qemu-system-x86_64 -preconfig -monitor stdio
> QEMU 2.12.50 monitor - type 'help' for more information
> (qemu) info mtree
> address-space: memory
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
>
> address-space: I/O
> 0000000000000000-000000000000ffff (prio 0, i/o): io
>
> But it's fine to enable that I guess.
>
> (Which "info" command would you want to use during preconfig?)
>
>>
>> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
>
> Reviewed-by: Peter Xu <address@hidden>
The reason for having -preconfig is us despairing of making -S do the
right thing. We'd have to *understand* the tangled mess that is our
startup, and rearrange it so QMP becomes available early enough for
configuring NUMA (and other things), yet late enough for everything to
work.
-preconfig is a cheap hack to avoid this headache, by bypassing almost
all of "everything".
Now you bring back some of "everything". Dangerous. You better show it
actually works. Until you do:
NAK
- [Qemu-devel] [PATCH 2/6] hmp: Allow help on preconfig commands, (continued)
- [Qemu-devel] [PATCH 2/6] hmp: Allow help on preconfig commands, Dr. David Alan Gilbert (git), 2018/06/05
- [Qemu-devel] [PATCH 1/6] hmp: Add flag for preconfig commands, Dr. David Alan Gilbert (git), 2018/06/05
- [Qemu-devel] [PATCH 3/6] hmp: Restrict auto-complete in preconfig, Dr. David Alan Gilbert (git), 2018/06/05
- [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert (git), 2018/06/05
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Peter Xu, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08