qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 5/5] slirp: reformat m_inc routine


From: Samuel Thibault
Subject: [Qemu-devel] [PULL 5/5] slirp: reformat m_inc routine
Date: Fri, 8 Jun 2018 09:13:16 +0300

From: Prasad J Pandit <address@hidden>

Coding style changes to the m_inc routine and minor refactoring.

Reported-by: ZDI Disclosures <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Signed-off-by: Samuel Thibault <address@hidden>
---
 slirp/mbuf.c | 34 ++++++++++++++++------------------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/slirp/mbuf.c b/slirp/mbuf.c
index 18cbf759a7..0c189e1a7b 100644
--- a/slirp/mbuf.c
+++ b/slirp/mbuf.c
@@ -151,27 +151,25 @@ m_cat(struct mbuf *m, struct mbuf *n)
 void
 m_inc(struct mbuf *m, int size)
 {
-       int datasize;
+    int datasize;
 
-       /* some compiles throw up on gotos.  This one we can fake. */
-        if(m->m_size>size) return;
+    /* some compilers throw up on gotos.  This one we can fake. */
+    if (m->m_size > size) {
+        return;
+    }
 
-        if (m->m_flags & M_EXT) {
-         datasize = m->m_data - m->m_ext;
-         m->m_ext = g_realloc(m->m_ext, size + datasize);
-         m->m_data = m->m_ext + datasize;
-        } else {
-         char *dat;
-         datasize = m->m_data - m->m_dat;
-         dat = g_malloc(size + datasize);
-         memcpy(dat, m->m_dat, m->m_size);
-
-         m->m_ext = dat;
-         m->m_data = m->m_ext + datasize;
-         m->m_flags |= M_EXT;
-        }
+    if (m->m_flags & M_EXT) {
+        datasize = m->m_data - m->m_ext;
+        m->m_ext = g_realloc(m->m_ext, size + datasize);
+    } else {
+        datasize = m->m_data - m->m_dat;
+        m->m_ext = g_malloc(size + datasize);
+        memcpy(m->m_ext, m->m_dat, m->m_size);
+        m->m_flags |= M_EXT;
+    }
 
-        m->m_size = size + datasize;
+    m->m_data = m->m_ext + datasize;
+    m->m_size = size + datasize;
 }
 
 
-- 
2.17.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]