[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer |
Date: |
Fri, 8 Jun 2018 15:37:47 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Fri, Jun 08, 2018 at 11:30:26AM -0300, Eduardo Habkost wrote:
> All of the supported build platforms documented in qemu-doc.texi
> should already support Python 2.7.
>
> Removing support for Python 2.6 will allow us to remove some
> compatibility modules we carry in the QEMU tree:
>
> * scripts/argparse.py
> * scripts/ordereddict.py
Lets delete those in this patch then....
>
> Python 2.6 is also not receiving bug fixes upstream and is not
> supported by pylint, which makes it harder to keep the code
> compatible with both Python 2 and Python 3.
Agreed, there's no compelling reason for 2.6 to stay around
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 14b11130a7..a8c4094c87 100755
> --- a/configure
> +++ b/configure
> @@ -1651,8 +1651,8 @@ fi
>
> # Note that if the Python conditional here evaluates True we will exit
> # with status 1 which is a shell 'false' value.
> -if ! $python -c 'import sys; sys.exit(sys.version_info < (2,6))'; then
> - error_exit "Cannot use '$python', Python 2 >= 2.6 or Python 3 is
> required." \
> +if ! $python -c 'import sys; sys.exit(sys.version_info < (2,7))'; then
> + error_exit "Cannot use '$python', Python 2 >= 2.7 or Python 3 is
> required." \
> "Use --python=/path/to/python to specify a supported Python."
> fi
>
> --
> 2.18.0.rc1.1.g3f1ff2140
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Eduardo Habkost, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Philippe Mathieu-Daudé, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer,
Daniel P . Berrangé <=
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Eduardo Habkost, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Daniel P . Berrangé, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Cleber Rosa, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, John Snow, 2018/06/08
- Re: [Qemu-devel] [PATCH] configure: Require Python 2.7 or newer, Stefan Hajnoczi, 2018/06/11