[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features |
Date: |
Sat, 9 Jun 2018 12:38:29 +0100 |
On 8 June 2018 at 19:47, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 06/08/2018 02:52 PM, Philippe Mathieu-Daudé wrote:
>> So 'rm ${srcdir}/qemu-version.h ${srcdir}/qemu-options.def' fixed my
>> problems.
>>
>> Should we add a check for this kind of mistakes when running out-of-tree
>> builds? I'll try something.
We do have a rune in the makefile that checks for whether you
have a stale in-tree build and you do an out-of-tree build,
and we also should refuse to do an in-tree build without
generating any extra files. Unfortunately we didn't always
have the rules for the latter correct, so in the past it
was possible to generate stray generated files, which then
lurk around until they cause a problem months later.
thanks
-- PMM
- [Qemu-devel] [PULL 27/31] arch_init: sort architectures, (continued)
- [Qemu-devel] [PULL 27/31] arch_init: sort architectures, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 28/31] tests/.gitignore: add entry for generated file, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 29/31] nvdimm, acpi: support NFIT platform capabilities, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 26/31] ui: use local path for local headers, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 23/31] migration: use local path for local headers, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 30/31] ACPI testing: test NFIT platform capabilities, Michael S. Tsirkin, 2018/06/01
- [Qemu-devel] [PULL 31/31] vhost-blk: turn on pre-defined RO feature bit, Michael S. Tsirkin, 2018/06/01
- Re: [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features, Peter Maydell, 2018/06/04
- Re: [Qemu-devel] [PULL 00/31] acpi, vhost, misc: fixes, features, Thomas Huth, 2018/06/06