Re: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 000/108] linux-user: Split do_syscall

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
142736fa01 linux-user: Fold away do_syscall1
b2fe320d4d linux-user: Split out setns, unshare
33ff337032 linux-user: Split out ioprio_get, ioprio_set, kcmp
3ee28ca711 linux-user: Split out timerfd syscalls
5537a2d2ce linux-user: Split out timer syscalls
956dc14fee linux-user: Split out atomic_cmpxchg_32
e7a1e5442b linux-user: Split out atomic_barrier, gethostname
b795dc37af linux-user: Split out prlimit64
b872c05a7b linux-user: Split out epoll syscalls
2b1db10c6b linux-user: Split out signalfd, signalfd4
69c7eef49d linux-user: Split out fallocate, sync_file_range/2
41b5a76976 linux-user: Split out eventfd, eventfd2
7aaafd89f6 linux-user: Split out splice, tee, vmsplice
961a2eb243 linux-user: Split out mq syscalls
64070cf90c linux-user: Split out inotify syscalls
09338954b0 linux-user: Remove sys_futex
984e9f5622 linux-user: Split out futex, utimensat
bd7c9988f3 linux-user: Split out set_tid_address, tgkill, tkill
2b632458ae linux-user: Fix clock_nanosleep
3a312f25d3 linux-user: Split out clock syscalls
abe5a1b94d linux-user: Split out getdomainname, get_thread_area, set_thread_area
0722311d8c linux-user: Split out xattr syscalls
570cf4cf05 linux-user: Split out gettid, readahead
863d38626f linux-user: Split out cacheflush, fcntl64, getpagesize, madvise
ab4c8863c6 linux-user: Split out fadvise64, fadvise64_64
65f8f2263b linux-user: Split out mincore
27893e3664 linux-user: Split out chown32, setfsgid32, setfsuid32, setgid32, 
setuid32
c46299c2db linux-user: Split out getresgid32, getresuid32, setresgid32, 
setresuid32
84a40d4226 linux-user: Split out fchown32, getgroups32, setgroups32
db41e152e5 linux-user: Split out getegid32, geteuid32, getgid32, setregid32, 
setreuid32
a0c6ad4e91 linux-user: Split out osf_getsysinfo, osf_setsysinfo, osf_sigprocmask
d344b150d9 linux-user: Split out getuid32, getxgid, getxuid, lchown32
e074a94e8f linux-user: Split out setfsgid, setfsuid, setgid, setuid
8613205669 linux-user: Split out chown, getresgid, getresuid
ca3e6e25ee linux-user: Split out fchown, fchownat, setresgid, setresuid
c4b670a25b linux-user: Split out getgroups, setgroups, setregid, setreuid
e9ea9a67b8 linux-user: Split out getegid, geteuid, getgid, getuid, lchown
8cf5c522fe linux-user: Split out fstat64, fstatat64, newfstatat, lstat64, stat64
a7aed32bd2 linux-user: Split out ftruncate64, truncate64, ugetrlimit, vfork
cebb6ef034 linux-user: Split out sendfile, sendfile64
bd2685b32a linux-user: Split out capget, capset
04ec16bc18 linux-user: Split out getcwd, pread64, pwrite64, sigaltstack
6e31fdfe46 linux-user: Split out arch_prctl
0099ab046e linux-user: Split out getcpu, nanosleep, prctl
64abc0d8c0 linux-user: Split out sched syscalls
da229f4f47 linux-user: Split out fdatasync, getsid, _sysctl
309936b671 linux-user: Split out flock, preadv, pwritev, readv, writev
22eb82902c linux-user: Split out poll, ppoll
b2c1d23350 linux-user: Split out getdents, getdents64
8d6564790a linux-user: Split out fchdir, getpgid, llseek, personality
c03d18c884 linux-user: Split out adjtimex, clock_adjtime, vm86
7203e31f9a linux-user: Split out modify_ldt, setdomainname, uname
e0f3e1ae92 linux-user: Split out clone, exit_group, fsync
d5f6938594 linux-user: Split out ipc syscalls
206d20e09d linux-user: Split out ipc
a8ff1f9c61 linux-user: Split out swapoff, sysinfo, vhangup, wait4
a96df8a712 linux-user: Unwrap TARGET_NR_syscall early
39526d0b45 linux-user: Split out fstat, lstat, stat
c8dc0c7596 linux-user: Split out getitimer, setitimer, syslog
01d065020b linux-user: Fix stub gettid
d89802d484 linux-user: Split out getrandom, shutdown, setsockopt, socket, 
socketpair
43a8fed411 linux-user: Split out recvmmsg, send, sendmmsg, sendmsg, sendto
6d6f6b0903 linux-user: Split out 7 syscalls
86639c65aa linux-user: Split out accept, accept4, bind, connect
21aa01481b linux-user: Split out socketcall
aafdcc007c linux-user: Split out getpriority, setpriority
14a6348a73 linux-user: Split out fstatfs, fstatfs64, statfs, statfs64
ff2d572b96 linux-user: Split out fchmod, fchmodat, ftruncate, truncate
8994add885 linux-user: Split out mlock, mlockall, munlock, munlockall
5d517b07ee linux-user: Split out mprotect, mremap, msync, munmap
756b5a7202 linux-user: Split out mmap, mmap2, reboot, swapon
dc9c3cb856 linux-user: Split out readlink, readlinkat
59a76e3a59 linux-user: Split out symlink, symlinkat
f731972ba9 linux-user: Split out select, pselect6, newselect
2edfe69a2e linux-user: Split out getrlimit, getrusage, gettimeofday, 
settimeofday
18aa8ff445 linux-user: Split out rt_sigreturn, sethostname, setrlimit, sigreturn
6687654059 linux-user: Split out rt_sigqueueinfo, rt_sigtimedwait, 
rt_tgsigqueueinfo
1bdc78b2f5 linux-user: Split out rt_sigpending, rt_sigsuspend, sigpending, 
sigsuspend
46720dcba9 linux-user: Split out rt_sigprocmask, sgetmask, sigprocmask, ssetmask
425e2caad8 linux-user: Split out rt_sigaction, sigaction
f41d33e02c linux-user: Split out getpgrp, getppid, setsid
7cec32d139 linux-user: Split out chroot, dup2, dup3, fcntl, setpgid, umask
583c2e1a87 linux-user: Split out ioctl
09798331c5 linux-user: Split out acct, pipe, pipe2, times, umount2
1c9f99810a linux-user: Split out dup, mkdir, mkdirat, rmdir
f65bfb57e0 linux-user: Split out rename, renameat, renameat2
e150ec4e3a linux-user: Split out access, faccessat, futimesat, kill, nice, 
sync, syncfs
4f48d262f9 linux-user: Split out alarm, pause, stime, utime, utimes
3050953a7a linux-user: Split out mount, umount
cd012801d4 linux-user: Split out getpid, getxpid, lseek
b2b2f13dce linux-user: Split out chdir, mknod, mknodat, time, chmod
35fa2508f8 linux-user: Split out unlink, unlinkat
2dbc0673fe linux-user: Split out link, linkat
256c818331 linux-user: Split out creat, fork, waitid, waitpid
4755e70b9b linux-user: Split out open_to_handle_at
472ad288c2 linux-user: Split out name_to_handle_at
b130be5247 linux-user: Split out open, openat
b8369df267 linux-user: Split out execve
fd1ec09ca4 linux-user: Split out brk, close, exit, read, write
4059c672d0 linux-user: Set up infrastructure for table-izing syscalls
e7c3c884d9 linux-user: Make syscall number unsigned
f0e92210cc linux-user: Propagate goto fail to return
127dd9fbe1 linux-user: Propagate goto unimplemented to default
2db600f0f7 linux-user: Propagate goto unimplemented_nowarn to return
c0b2105c4a linux-user: Propagate goto efault to return
4c16dbe787 linux-user: Relax single exit from "break"
78abe22609 linux-user: Split out do_syscall1
7f0b7b14c2 linux-user: Remove DEBUG

=== OUTPUT BEGIN ===
Checking PATCH 1/108: linux-user: Remove DEBUG...
Checking PATCH 2/108: linux-user: Split out do_syscall1...
Checking PATCH 3/108: linux-user: Relax single exit from "break"...
Checking PATCH 4/108: linux-user: Propagate goto efault to return...
ERROR: do not use assignment in if condition
#257: FILE: linux-user/syscall.c:8465:
+            if (!(p = lock_user_string(arg2))) {

ERROR: do not use assignment in if condition
#269: FILE: linux-user/syscall.c:8483:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#280: FILE: linux-user/syscall.c:8492:
+        if (!(p = lock_user_string(arg2))) {

ERROR: do not use assignment in if condition
#328: FILE: linux-user/syscall.c:8631:
+            if (!(p = lock_user_string(arg1))) {

ERROR: suspect code indent for conditional statements (11, 15)
#652: FILE: linux-user/syscall.c:9462:
            if (!p) {
+               return -TARGET_EFAULT;

ERROR: do not use assignment in if condition
#691: FILE: linux-user/syscall.c:9596:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#712: FILE: linux-user/syscall.c:9632:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#767: FILE: linux-user/syscall.c:9838:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#778: FILE: linux-user/syscall.c:9847:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#1084: FILE: linux-user/syscall.c:10938:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#1096: FILE: linux-user/syscall.c:10949:
+        if (!(p = lock_user_string(arg1))) {

ERROR: do not use assignment in if condition
#1108: FILE: linux-user/syscall.c:10972:
+        if (!(p = lock_user_string(arg2))) {

total: 12 errors, 0 warnings, 1228 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/108: linux-user: Propagate goto unimplemented_nowarn to 
return...
Checking PATCH 6/108: linux-user: Propagate goto unimplemented to default...
Checking PATCH 7/108: linux-user: Propagate goto fail to return...
Checking PATCH 8/108: linux-user: Make syscall number unsigned...
Checking PATCH 9/108: linux-user: Set up infrastructure for table-izing 
syscalls...
Checking PATCH 10/108: linux-user: Split out brk, close, exit, read, write...
Checking PATCH 11/108: linux-user: Split out execve...
Checking PATCH 12/108: linux-user: Split out open, openat...
Checking PATCH 13/108: linux-user: Split out name_to_handle_at...
Checking PATCH 14/108: linux-user: Split out open_to_handle_at...
Checking PATCH 15/108: linux-user: Split out creat, fork, waitid, waitpid...
Checking PATCH 16/108: linux-user: Split out link, linkat...
Checking PATCH 17/108: linux-user: Split out unlink, unlinkat...
Checking PATCH 18/108: linux-user: Split out chdir, mknod, mknodat, time, 
chmod...
Checking PATCH 19/108: linux-user: Split out getpid, getxpid, lseek...
Checking PATCH 20/108: linux-user: Split out mount, umount...
Checking PATCH 21/108: linux-user: Split out alarm, pause, stime, utime, 
utimes...
Checking PATCH 22/108: linux-user: Split out access, faccessat, futimesat, 
kill, nice, sync, syncfs...
Checking PATCH 23/108: linux-user: Split out rename, renameat, renameat2...
Checking PATCH 24/108: linux-user: Split out dup, mkdir, mkdirat, rmdir...
Checking PATCH 25/108: linux-user: Split out acct, pipe, pipe2, times, 
umount2...
Checking PATCH 26/108: linux-user: Split out ioctl...
Checking PATCH 27/108: linux-user: Split out chroot, dup2, dup3, fcntl, 
setpgid, umask...
Checking PATCH 28/108: linux-user: Split out getpgrp, getppid, setsid...
Checking PATCH 29/108: linux-user: Split out rt_sigaction, sigaction...
Checking PATCH 30/108: linux-user: Split out rt_sigprocmask, sgetmask, 
sigprocmask, ssetmask...
Checking PATCH 31/108: linux-user: Split out rt_sigpending, rt_sigsuspend, 
sigpending, sigsuspend...
Checking PATCH 32/108: linux-user: Split out rt_sigqueueinfo, rt_sigtimedwait, 
rt_tgsigqueueinfo...
Checking PATCH 33/108: linux-user: Split out rt_sigreturn, sethostname, 
setrlimit, sigreturn...
Checking PATCH 34/108: linux-user: Split out getrlimit, getrusage, 
gettimeofday, settimeofday...
Checking PATCH 35/108: linux-user: Split out select, pselect6, newselect...
Checking PATCH 36/108: linux-user: Split out symlink, symlinkat...
Checking PATCH 37/108: linux-user: Split out readlink, readlinkat...
Checking PATCH 38/108: linux-user: Split out mmap, mmap2, reboot, swapon...
Checking PATCH 39/108: linux-user: Split out mprotect, mremap, msync, munmap...
Checking PATCH 40/108: linux-user: Split out mlock, mlockall, munlock, 
munlockall...
Checking PATCH 41/108: linux-user: Split out fchmod, fchmodat, ftruncate, 
truncate...
Checking PATCH 42/108: linux-user: Split out fstatfs, fstatfs64, statfs, 
statfs64...
Checking PATCH 43/108: linux-user: Split out getpriority, setpriority...
Checking PATCH 44/108: linux-user: Split out socketcall...
Checking PATCH 45/108: linux-user: Split out accept, accept4, bind, connect...
Checking PATCH 46/108: linux-user: Split out 7 syscalls...
Checking PATCH 47/108: linux-user: Split out recvmmsg, send, sendmmsg, sendmsg, 
sendto...
Checking PATCH 48/108: linux-user: Split out getrandom, shutdown, setsockopt, 
socket, socketpair...
WARNING: architecture specific defines should be avoided
#25: FILE: linux-user/syscall.c:256:
+#ifndef __NR_getrandom

total: 0 errors, 1 warnings, 166 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 49/108: linux-user: Fix stub gettid...
WARNING: architecture specific defines should be avoided
#32: FILE: linux-user/syscall.c:259:
+#ifndef __NR_gettid

total: 0 errors, 1 warnings, 21 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 50/108: linux-user: Split out getitimer, setitimer, syslog...
Checking PATCH 51/108: linux-user: Split out fstat, lstat, stat...
Checking PATCH 52/108: linux-user: Unwrap TARGET_NR_syscall early...
Checking PATCH 53/108: linux-user: Split out swapoff, sysinfo, vhangup, wait4...
Checking PATCH 54/108: linux-user: Split out ipc...
Checking PATCH 55/108: linux-user: Split out ipc syscalls...
Checking PATCH 56/108: linux-user: Split out clone, exit_group, fsync...
WARNING: architecture specific defines should be avoided
#43: FILE: linux-user/syscall.c:7995:
+#ifdef __NR_exit_group

WARNING: architecture specific defines should be avoided
#116: FILE: linux-user/syscall.c:12907:
+#ifdef __NR_exit_group

total: 0 errors, 2 warnings, 112 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 57/108: linux-user: Split out modify_ldt, setdomainname, uname...
Checking PATCH 58/108: linux-user: Split out adjtimex, clock_adjtime, vm86...
Checking PATCH 59/108: linux-user: Split out fchdir, getpgid, llseek, 
personality...
Checking PATCH 60/108: linux-user: Split out getdents, getdents64...
WARNING: architecture specific defines should be avoided
#148: FILE: linux-user/syscall.c:8255:
+#if defined(TARGET_NR_getdents64) && defined(__NR_getdents64)

WARNING: architecture specific defines should be avoided
#357: FILE: linux-user/syscall.c:12951:
+#if defined(TARGET_NR_getdents64) && defined(__NR_getdents64)

total: 0 errors, 2 warnings, 347 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 61/108: linux-user: Split out poll, ppoll...
Checking PATCH 62/108: linux-user: Split out flock, preadv, pwritev, readv, 
writev...
Checking PATCH 63/108: linux-user: Split out fdatasync, getsid, _sysctl...
Checking PATCH 64/108: linux-user: Split out sched syscalls...
Checking PATCH 65/108: linux-user: Split out getcpu, nanosleep, prctl...
Checking PATCH 66/108: linux-user: Split out arch_prctl...
Checking PATCH 67/108: linux-user: Split out getcwd, pread64, pwrite64, 
sigaltstack...
Checking PATCH 68/108: linux-user: Split out capget, capset...
Checking PATCH 69/108: linux-user: Split out sendfile, sendfile64...
Checking PATCH 70/108: linux-user: Split out ftruncate64, truncate64, 
ugetrlimit, vfork...
Checking PATCH 71/108: linux-user: Split out fstat64, fstatat64, newfstatat, 
lstat64, stat64...
Checking PATCH 72/108: linux-user: Split out getegid, geteuid, getgid, getuid, 
lchown...
Checking PATCH 73/108: linux-user: Split out getgroups, setgroups, setregid, 
setreuid...
Checking PATCH 74/108: linux-user: Split out fchown, fchownat, setresgid, 
setresuid...
Checking PATCH 75/108: linux-user: Split out chown, getresgid, getresuid...
Checking PATCH 76/108: linux-user: Split out setfsgid, setfsuid, setgid, 
setuid...
Checking PATCH 77/108: linux-user: Split out getuid32, getxgid, getxuid, 
lchown32...
Checking PATCH 78/108: linux-user: Split out osf_getsysinfo, osf_setsysinfo, 
osf_sigprocmask...
Checking PATCH 79/108: linux-user: Split out getegid32, geteuid32, getgid32, 
setregid32, setreuid32...
Checking PATCH 80/108: linux-user: Split out fchown32, getgroups32, 
setgroups32...
Checking PATCH 81/108: linux-user: Split out getresgid32, getresuid32, 
setresgid32, setresuid32...
Checking PATCH 82/108: linux-user: Split out chown32, setfsgid32, setfsuid32, 
setgid32, setuid32...
Checking PATCH 83/108: linux-user: Split out mincore...
Checking PATCH 84/108: linux-user: Split out fadvise64, fadvise64_64...
Checking PATCH 85/108: linux-user: Split out cacheflush, fcntl64, getpagesize, 
madvise...
Checking PATCH 86/108: linux-user: Split out gettid, readahead...
Checking PATCH 87/108: linux-user: Split out xattr syscalls...
Checking PATCH 88/108: linux-user: Split out getdomainname, get_thread_area, 
set_thread_area...
Checking PATCH 89/108: linux-user: Split out clock syscalls...
Checking PATCH 90/108: linux-user: Fix clock_nanosleep...
Checking PATCH 91/108: linux-user: Split out set_tid_address, tgkill, tkill...
WARNING: architecture specific defines should be avoided
#20: FILE: linux-user/syscall.c:253:
+#ifndef __NR_set_tid_address

total: 0 errors, 1 warnings, 90 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 92/108: linux-user: Split out futex, utimensat...
WARNING: architecture specific defines should be avoided
#22: FILE: linux-user/syscall.c:605:
+#ifdef __NR_utimensat

total: 0 errors, 1 warnings, 209 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 93/108: linux-user: Remove sys_futex...
Checking PATCH 94/108: linux-user: Split out inotify syscalls...
Checking PATCH 95/108: linux-user: Split out mq syscalls...
Checking PATCH 96/108: linux-user: Split out splice, tee, vmsplice...
Checking PATCH 97/108: linux-user: Split out eventfd, eventfd2...
Checking PATCH 98/108: linux-user: Split out fallocate, sync_file_range/2...
Checking PATCH 99/108: linux-user: Split out signalfd, signalfd4...
Checking PATCH 100/108: linux-user: Split out epoll syscalls...
Checking PATCH 101/108: linux-user: Split out prlimit64...
Checking PATCH 102/108: linux-user: Split out atomic_barrier, gethostname...
Checking PATCH 103/108: linux-user: Split out atomic_cmpxchg_32...
Checking PATCH 104/108: linux-user: Split out timer syscalls...
Checking PATCH 105/108: linux-user: Split out timerfd syscalls...
Checking PATCH 106/108: linux-user: Split out ioprio_get, ioprio_set, kcmp...
WARNING: architecture specific defines should be avoided
#19: FILE: linux-user/syscall.c:253:
+#ifndef __NR_ioprio_get

WARNING: architecture specific defines should be avoided
#22: FILE: linux-user/syscall.c:256:
+#ifndef __NR_ioprio_set

WARNING: architecture specific defines should be avoided
#25: FILE: linux-user/syscall.c:259:
+#ifndef __NR_kcmp

total: 0 errors, 3 warnings, 99 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 107/108: linux-user: Split out setns, unshare...
Checking PATCH 108/108: linux-user: Fold away do_syscall1...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden