Re: [Qemu-devel] [PATCH 1/2] python: Remove scripts/argparse.py

[Eduardo Habkost]

On Mon, Jun 11, 2018 at 10:27:21AM +0100, Daniel P. Berrangé wrote:
> On Fri, Jun 08, 2018 at 02:35:57PM -0300, Eduardo Habkost wrote:
> > Python 2.7 (the minimum Python version we require) already
> > provides the argparse module on the standard library.
> > 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> >  scripts/argparse.py | 2406 -------------------------------------------
> >  1 file changed, 2406 deletions(-)
> >  delete mode 100644 scripts/argparse.py
> 
> When this was added in 47e1cb1f0a130baa438d895eff5d05004c9a9aa2, it
> also added a COPYING.PYTHON file so that needs removing  in this
> commit too - eg a straight revert of that commit.

Thanks for noting that.  This is already in a pull request, so
I'm sending a separate patch.

> 
> Second, various source files were then modified to add 'scripts' to
> their import path with a line like this:
> 
>  sys.path.append(os.path.join(os.path.dirname(__file__),
>                              '..', '..', 'scripts'))
> 
> so those all need removing too, but I'd suggest that is done
> as a separate patch.

I have the impression that most scripts do this trick to be able
to use other modules like 'qemu' and 'qmp' too.  In either case,
we need to review the code to find out.  I will take a look.

-- 
Eduardo