[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 3/7] block/dirty-bitmap: add lock to bdrv_enable/disa
From: |
John Snow |
Subject: |
[Qemu-devel] [PULL 3/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap |
Date: |
Mon, 11 Jun 2018 15:34:30 -0400 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
Add locks and remove comments about BQL accordingly to
dirty_bitmap_mutex definition in block_int.h.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: John Snow <address@hidden>
---
block/dirty-bitmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
index a7eaa1051d..59b38b2671 100644
--- a/block/dirty-bitmap.c
+++ b/block/dirty-bitmap.c
@@ -413,18 +413,20 @@ void bdrv_remove_persistent_dirty_bitmap(BlockDriverState
*bs,
}
}
-/* Called with BQL taken. */
void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
{
+ bdrv_dirty_bitmap_lock(bitmap);
assert(!bdrv_dirty_bitmap_frozen(bitmap));
bitmap->disabled = true;
+ bdrv_dirty_bitmap_unlock(bitmap);
}
-/* Called with BQL taken. */
void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap)
{
+ bdrv_dirty_bitmap_lock(bitmap);
assert(!bdrv_dirty_bitmap_frozen(bitmap));
bitmap->disabled = false;
+ bdrv_dirty_bitmap_unlock(bitmap);
}
BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs)
--
2.14.3
- [Qemu-devel] [PULL 0/7] Bitmaps patches, John Snow, 2018/06/11
- [Qemu-devel] [PULL 1/7] block: remove bdrv_dirty_bitmap_make_anon, John Snow, 2018/06/11
- [Qemu-devel] [PULL 4/7] qapi: add x-block-dirty-bitmap-enable/disable, John Snow, 2018/06/11
- [Qemu-devel] [PULL 3/7] block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap,
John Snow <=
- [Qemu-devel] [PULL 5/7] qmp: transaction support for x-block-dirty-bitmap-enable/disable, John Snow, 2018/06/11
- [Qemu-devel] [PULL 2/7] block: simplify code around releasing bitmaps, John Snow, 2018/06/11
- [Qemu-devel] [PULL 6/7] qapi: add x-block-dirty-bitmap-merge, John Snow, 2018/06/11
- [Qemu-devel] [PULL 7/7] qapi: add disabled parameter to block-dirty-bitmap-add, John Snow, 2018/06/11
- Re: [Qemu-devel] [PULL 0/7] Bitmaps patches, Peter Maydell, 2018/06/12