[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name |
Date: |
Mon, 11 Jun 2018 17:37:12 -0300 |
RFC NOTE: Paolo, Richard, as far as I can see, there's no point
in enabling OSPKE in user-mode QEMU. Do you confirm that?
OSPKE is not a static feature flag: it changes dynamically at
runtime depending on CR4, and it was never configurable: KVM
never returned OSPKE on GET_SUPPORTED_CPUID, and on TCG enables
it automatically if CR4_PKE_MASK is set.
Remove OSPKE from the feature name array so users don't try to
configure it manually.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target/i386/cpu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 94260412e2..f101771ac0 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -564,7 +564,8 @@ static void x86_cpu_vendor_words2str(char *dst, uint32_t
vendor1,
CPUID_7_0_EBX_HLE, CPUID_7_0_EBX_AVX2,
CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM,
CPUID_7_0_EBX_RDSEED */
-#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE | \
+#define TCG_7_0_ECX_FEATURES (CPUID_7_0_ECX_PKU | \
+ /* CPUID_7_0_ECX_OSPKE is dynamic */ \
CPUID_7_0_ECX_LA57)
#define TCG_7_0_EDX_FEATURES 0
#define TCG_APM_FEATURES 0
@@ -781,7 +782,7 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = {
[FEAT_7_0_ECX] = {
.feat_names = {
NULL, "avx512vbmi", "umip", "pku",
- "ospke", NULL, "avx512vbmi2", NULL,
+ NULL /* ospke */, NULL, "avx512vbmi2", NULL,
"gfni", "vaes", "vpclmulqdq", "avx512vnni",
"avx512bitalg", NULL, "avx512-vpopcntdq", NULL,
"la57", NULL, NULL, NULL,
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name,
Eduardo Habkost <=
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Richard Henderson, 2018/06/11
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/12
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/13
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Eduardo Habkost, 2018/06/13
- Re: [Qemu-devel] [RFC PATCH] i386: Remove ospke CPUID flag name, Paolo Bonzini, 2018/06/13