[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authen
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication |
Date: |
Tue, 12 Jun 2018 18:41:55 +0200 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben:
> PATCH 01-17 are configuration fixes and cleanup, in particular
> -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with
> non-string scalars.
>
> PATCH 18-19 provide support for configuring rbd authentication.
>
> I'm happy to split the series if that helps.
>
> Since the RFC post, I amended the documentation of the rbd
> authentication parameters, and squashed PATCH 04 into 03.
>
> Jeff Cody tested the RFC on his Ceph rig. All results match
> expectations.
>
> The series clashes with Max's "[PATCH 00/13] block: Try to create well
> typed json:{} filenames", but Max has rebased his work on mine.
I had minor, but still non-trivial comments for patches 9 and 12. The
rest is:
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH 09/18] block: Make remaining uses of qobject input visitor more robust, (continued)
- [Qemu-devel] [PATCH 09/18] block: Make remaining uses of qobject input visitor more robust, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 17/18] rbd: New parameter auth-client-required, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 18/18] rbd: New parameter key-secret, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 07/18] block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 16/18] block: Fix -blockdev / blockdev-add for empty objects and arrays, Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 08/18] block: Factor out qobject_input_visitor_new_flat_confused(), Markus Armbruster, 2018/06/12
- [Qemu-devel] [PATCH 04/18] qobject: Move block-specific qdict code to block-qdict.c, Markus Armbruster, 2018/06/12
- Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication, Kevin Wolf, 2018/06/12
- Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication,
Kevin Wolf <=