Re: [Qemu-devel] [PATCH 2/3] exec.c: Don't accidentally sign-extend 4-byte loads in subpage_read()

[Richard Henderson]

On 06/11/2018 07:10 AM, Peter Maydell wrote:
> In subpage_read() we perform a load of the data into a local buffer
> which we then access using ldub_p(), lduw_p(), ldl_p() or ldq_p()
> depending on its size, storing the result into the uint64_t *data.
> Since ldl_p() returns an 'int', this means that for the 4-byte
> case we will sign-extend the data, whereas for 1 and 2 byte
> reads we zero-extend it.
> 
> This ought not to matter since the caller will likely ignore values in
> the high bytes of the data, but add a cast so that we're consistent.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---

Reviewed-by: Richard Henderson <address@hidden>


r~