[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 17/19] translate-all: remove tb_lock mention from
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PULL v2 17/19] translate-all: remove tb_lock mention from cpu_restore_state_from_tb |
Date: |
Fri, 15 Jun 2018 09:43:52 -1000 |
From: "Emilio G. Cota" <address@hidden>
tb_lock was needed when the function did retranslation. However,
since fca8a500d519 ("tcg: Save insn data and use it in
cpu_restore_state_from_tb") we don't do retranslation.
Get rid of the comment.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/translate-all.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 55c9e1b196..b33cd9bc98 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t
*block)
}
/* The cpu state corresponding to 'searched_pc' is restored.
- * Called with tb_lock held.
* When reset_icount is true, current TB will be interrupted and
* icount should be recalculated.
*/
--
2.17.1
- [Qemu-devel] [PULL v2 06/19] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB, (continued)
- [Qemu-devel] [PULL v2 06/19] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 08/19] translate-all: remove hole in PageDesc, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 07/19] translate-all: make l1_map lockless, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 09/19] translate-all: work page-by-page in tb_invalidate_phys_range_1, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 10/19] translate-all: move tb_invalidate_phys_page_range up in the file, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 11/19] translate-all: use per-page locking in !user-mode, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 13/19] translate-all: introduce assert_no_pages_locked, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 12/19] translate-all: add page_locked assertions, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 14/19] translate-all: discard TB when tb_link_page returns an existing matching TB, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 16/19] cputlb: remove tb_lock from tlb_flush functions, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 17/19] translate-all: remove tb_lock mention from cpu_restore_state_from_tb,
Richard Henderson <=
- [Qemu-devel] [PULL v2 15/19] translate-all: protect TB jumps with a per-destination-TB lock, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 19/19] tcg: Reduce max TB opcode count, Richard Henderson, 2018/06/15
- [Qemu-devel] [PULL v2 18/19] tcg: remove tb_lock, Richard Henderson, 2018/06/15