Re: [Qemu-devel] [PATCH] target/arm: Allow ARMv6-M Thumb2 instructions

[Peter Maydell]

On 17 June 2018 at 06:36, Richard Henderson
<address@hidden> wrote:
> On 06/15/2018 12:55 AM, Peter Maydell wrote:
>>> +    uint32_t armv6m_insn[] = {0xf3808000 /* msr */, 0xf3b08040 /* dsb */,
>>> +                              0xf3b08050 /* dmb */, 0xf3b08060 /* isb */,
>>> +                              0xf3e08000 /* mrs */, 0xf000d000 /* bl */};
>>> +    uint32_t armv6m_mask[] = {0xffe0d000, 0xfff0d0f0, 0xfff0d0f0,
>>> +                              0xfff0d0f0, 0xffe0d000, 0xf800d000};
>> I think these arrays should be 'const'; we can also move them closer
>> to their point of use, inside the scope of the if() below.
>
> static as well.

Mmm; commit is already in master though, will need a followup patch.

thanks
-- PMM