[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/7] monitor: move init global earlier
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 6/7] monitor: move init global earlier |
Date: |
Mon, 18 Jun 2018 16:08:53 +0200 |
From: Peter Xu <address@hidden>
Before this patch, monitor fd helpers might be called even earlier than
monitor_init_globals(). This can be problematic.
After previous work, now monitor_init_globals() does not depend on
accelerator initialization any more. Call it earlier (before CLI
parsing; that's where the monitor APIs might be called) to make sure it
is called before any of the monitor APIs.
Suggested-by: Markus Armbruster <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
vl.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 6e34fb348d..b3426e03d0 100644
--- a/vl.c
+++ b/vl.c
@@ -2978,6 +2978,7 @@ int main(int argc, char **argv, char **envp)
runstate_init();
postcopy_infrastructure_init();
+ monitor_init_globals();
if (qcrypto_init(&err) < 0) {
error_reportf_err(err, "cannot initialize crypto: ");
@@ -4412,12 +4413,6 @@ int main(int argc, char **argv, char **envp)
default_drive(default_floppy, snapshot, IF_FLOPPY, 0, FD_OPTS);
default_drive(default_sdcard, snapshot, IF_SD, 0, SD_OPTS);
- /*
- * Note: qtest_enabled() (which is used in monitor_qapi_event_init())
- * depends on configure_accelerator() above.
- */
- monitor_init_globals();
-
if (qemu_opts_foreach(qemu_find_opts("mon"),
mon_init_func, NULL, NULL)) {
exit(1);
--
2.17.1
- [Qemu-devel] [PULL 0/7] monitor: Thread safety improvements, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 3/7] monitor: more comments on lock-free elements, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 1/7] monitor: rename out_lock to mon_lock, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 5/7] monitor: remove event_clock_type, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 7/7] monitor: add lock to protect mon_fdsets, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 4/7] monitor: fix comment for monitor_lock, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 2/7] monitor: protect mon->fds with mon_lock, Markus Armbruster, 2018/06/18
- [Qemu-devel] [PULL 6/7] monitor: move init global earlier,
Markus Armbruster <=
- Re: [Qemu-devel] [PULL 0/7] monitor: Thread safety improvements, Peter Maydell, 2018/06/19