Re: [Qemu-devel] [PATCH v3 26/26] hw/display: add vhost-user-vga & gpu-pci

[Marc-André Lureau]

Hi

On Tue, Jun 19, 2018 at 8:54 AM, Gerd Hoffmann <address@hidden> wrote:
>   Hi,
>
>> +    VHOST_USER_GPU_SCANOUT,
>> +    VHOST_USER_GPU_UPDATE,
>> +    VHOST_USER_GPU_DMABUF_SCANOUT,
>> +    VHOST_USER_GPU_DMABUF_UPDATE,
>
> Hmm, still two command versions.
>
> I still think there should be no separate 2d code path.  Just
> put the 2d display updates into a texture, or into a drm buffer,
> then use VHOST_USER_GPU_DMABUF_* for both 2d and 3d updates (see
> also ui/console-gl.c, which does basically the same).

It will use DMABUF for both 2d and 3d, unless it's not capable of
doing it (currently only intel gpu). So the regular scanout/update are
fallback. They share a lot of similarities.


-- 
Marc-André Lureau