[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/26] vhost-user: simplify vhost_user_init/v
|
From: |
Tiwei Bie |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 04/26] vhost-user: simplify vhost_user_init/vhost_user_cleanup |
|
Date: |
Thu, 21 Jun 2018 20:33:20 +0800 |
|
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Mon, Jun 18, 2018 at 06:17:07PM +0200, Marc-André Lureau wrote:
[...]
> diff --git a/hw/virtio/vhost-stub.c b/hw/virtio/vhost-stub.c
> index 049089b5e2..323dfcc46a 100644
> --- a/hw/virtio/vhost-stub.c
> +++ b/hw/virtio/vhost-stub.c
> @@ -7,7 +7,7 @@ bool vhost_has_free_slot(void)
> return true;
> }
>
> -VhostUserState *vhost_user_init(void)
> +bool vhost_user_init(VhostUserState *user, CharBackend *chr, Error **errp)
> {
> return NULL;
It would be better to return false.
Best regards,
Tiwei Bie
> }
[...]
- Re: [Qemu-devel] [PATCH v3 02/26] chardev: remove qemu_chr_fe_write_all() counter, (continued)
[Qemu-devel] [PATCH v3 05/26] libvhost-user: exit by default on VHOST_USER_NONE, Marc-André Lureau, 2018/06/18
[Qemu-devel] [PATCH v3 06/26] vhost-user: wrap some read/write with retry handling, Marc-André Lureau, 2018/06/18
[Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute, Marc-André Lureau, 2018/06/18
[Qemu-devel] [PATCH v3 07/26] qio: add qio_channel_command_new_spawn_with_pre_exec(), Marc-André Lureau, 2018/06/18
[Qemu-devel] [PATCH v3 08/26] Add vhost-user-backend, Marc-André Lureau, 2018/06/18