Re: [Qemu-devel] [PATCH 05/35] target/mips: Add nanoMIPS 16bit ld/st instructions

[Richard Henderson]

On 06/20/2018 05:05 AM, Yongbok Kim wrote:
> Add nanoMIPS 16bit load and store instructions
> 
> Signed-off-by: Yongbok Kim <address@hidden>
> ---
>  target/mips/translate.c | 110 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 110 insertions(+)
> 
> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index 633d0b4..f5b7e14 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -16207,6 +16207,14 @@ static int mmreg_nanomips(int r)
>      return map[r & 0x7];
>  }
>  
> +/* Used for 16-bit store instructions.  */
> +static int mmreg2_nanomips(int r)
> +{
> +    static const int map[] = { 0, 17, 18, 19, 4, 5, 6, 7 };
> +
> +    return map[r & 0x7];

This is called gpr3.src.store in the manual.
Why the name change to "reg2"?


r~