[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 09/10] qapi/introspect: Eliminate pointless variable
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 09/10] qapi/introspect: Eliminate pointless variable in .visit_end() |
Date: |
Fri, 22 Jun 2018 17:32:27 +0200 |
Commit 1a9a507b2e3 "qapi-introspect: Hide type names" added local
variable @jsons to improve sorting, but also removed the sorting. It
was part of a big series that went to v8, and it made sense until v2
or so...
Commit 7d0f982bfbb replaced @jsons by @qlits, preserving the
uselessness.
Get rid of it.
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
---
scripts/qapi/introspect.py | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 5b6c72c7b2..6ad198ae5b 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -75,13 +75,10 @@ class
QAPISchemaGenIntrospectVisitor(QAPISchemaMonolithicCVisitor):
def visit_end(self):
# visit the types that are actually used
- qlits = self._qlits
- self._qlits = []
for typ in self._used_types:
typ.visit(self)
# generate C
# TODO can generate awfully long lines
- qlits.extend(self._qlits)
name = c_name(self._prefix, protect=False) + 'qmp_schema_qlit'
self._genh.add(mcgen('''
#include "qapi/qmp/qlit.h"
@@ -93,7 +90,7 @@ extern const QLitObject %(c_name)s;
const QLitObject %(c_name)s = %(c_string)s;
''',
c_name=c_name(name),
- c_string=to_qlit(qlits)))
+ c_string=to_qlit(self._qlits)))
self._schema = None
self._qlits = []
self._used_types = []
--
2.17.1
- [Qemu-devel] [PULL 00/10] QAPI patches for 2018-06-22, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 02/10] qapi/events: generate event enum in main module, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 08/10] Revert commit d4e5ec877ca, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 03/10] qdict: Make qdict_flatten() shallow-clone-friendly, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 04/10] tests: Add QDict clone-flatten test, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 05/10] qapi: allow empty branches in flat unions, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 07/10] qapi: Open files with encoding='utf-8', Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 06/10] qapi: remove empty flat union branches and types, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 01/10] qapi/visit: remove useless prefix argument, Markus Armbruster, 2018/06/22
- [Qemu-devel] [PULL 09/10] qapi/introspect: Eliminate pointless variable in .visit_end(),
Markus Armbruster <=
- [Qemu-devel] [PULL 10/10] MAINTAINERS: Update QAPI stanza for commit fb0bc835e56, Markus Armbruster, 2018/06/22
- Re: [Qemu-devel] [PULL 00/10] QAPI patches for 2018-06-22, Peter Maydell, 2018/06/22