[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/5] pr-helper: fix --socket-path default in hel
From: |
Michal Privoznik |
Subject: |
Re: [Qemu-devel] [PATCH 1/5] pr-helper: fix --socket-path default in help |
Date: |
Tue, 26 Jun 2018 18:24:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/26/2018 05:40 PM, Paolo Bonzini wrote:
> Currently --help shows "(default '(null)')" for the -k/--socket-path
> option. Fix it by getting the default path in /var/run.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> scsi/qemu-pr-helper.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c
> index d0f83176e1..4057cf355c 100644
> --- a/scsi/qemu-pr-helper.c
> +++ b/scsi/qemu-pr-helper.c
> @@ -74,8 +74,16 @@ static int uid = -1;
> static int gid = -1;
> #endif
>
> +static void compute_default_paths(void)
> +{
> + if (!socket_path) {
> + socket_path =
> qemu_get_local_state_pathname("run/qemu-pr-helper.sock");
> + }
> +}
> +
Pre-existing, but pidfile path is computed elsewhere. I'll post a patch
that cleans things up. Not a show stopper for this one though.
Reviewed-by: Michal Privoznik <address@hidden>
Michal
[Qemu-devel] [PATCH 2/5] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN, Paolo Bonzini, 2018/06/26