Re: [Qemu-devel] [PATCH v2 3/5] migration: do explicit incoming setup for rdma

[Dr. David Alan Gilbert]

* Peter Xu (address@hidden) wrote:
> RDMA does not support postcopy recovery, so no need to go into such
> logic.  Instead of calling migration_fd_process_incoming(), let's call
> the two functions that setup the incoming migration.  There should have
> no functional change at all.

Can you explain why we need to though?  The reason I ask is that there
is Lidong Chen's work that gets postcopy partially working with RDMA, so
then the next question is bound to be recovery.

Dave

> Signed-off-by: Peter Xu <address@hidden>
> ---
>  migration/rdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 8bd7159059..217cdd7dd8 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -3687,7 +3687,8 @@ static void rdma_accept_incoming_migration(void *opaque)
>      }
>  
>      rdma->migration_started_on_destination = 1;
> -    migration_fd_process_incoming(f);
> +    migration_incoming_setup(f);
> +    migration_incoming_process();
>  }
>  
>  void rdma_start_incoming_migration(const char *host_port, Error **errp)
> -- 
> 2.17.1
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK