[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k |
|
Date: |
Wed, 27 Jun 2018 09:15:09 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/27/2018 09:03 AM, Philippe Mathieu-Daudé wrote:
>> +INSN(lwa, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lwz, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lws, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lbz, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lbs, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lhz, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(lhs, "r%d, %d(r%d)", a->d, a->i, a->a)
>> +INSN(swa, "%d(r%d), r%d", a->i, a->a, a->b)
>> +INSN(sw, "%d(r%d), r%d", a->i, a->a, a->b)
>> +INSN(sb, "%d(r%d), r%d", a->i, a->a, a->b)
>> +INSN(sh, "%d(r%d), r%d", a->i, a->a, a->b)
>
> You updated to use the offset(reg) notation, ok.
Yes, failure to match the usual format was confusing.
>> +INSN(nop, "")
>
> The nop previously displayed 'k', I suppose a left-over from sys/trap.
Yes, real nop has no argument.
r~
- [Qemu-devel] [PATCH v2 14/22] target/openrisc: Use identical sizes for ITLB and DTLB, (continued)
- [Qemu-devel] [PATCH v2 14/22] target/openrisc: Use identical sizes for ITLB and DTLB, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 15/22] target/openrisc: Stub out handle_mmu_fault for softmmu, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 18/22] target/openrisc: Reorg tlb lookup, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 20/22] target/openrisc: Add support in scripts/qemu-binfmt-conf.sh, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 22/22] linux-user: Fix struct sigaltstack for openrisc, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 21/22] linux-user: Implement signals for openrisc, Richard Henderson, 2018/06/18
- [Qemu-devel] [PATCH v2 19/22] target/openrisc: Add print_insn_or1k, Richard Henderson, 2018/06/18
- Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements, no-reply, 2018/06/18
- Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements, Stafford Horne, 2018/06/21