[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controlle
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller |
Date: |
Thu, 28 Jun 2018 11:04:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Le 28/06/2018 à 10:44, Kevin Wolf a écrit :
> Am 28.06.2018 um 01:23 hat Laurent Vivier geschrieben:
>> Co-developed-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
>
>> +static Property swim_properties[] = {
>> + DEFINE_PROP_DRIVE("driveA", SWIMCtrl, drives[0].blk),
>> + DEFINE_PROP_DRIVE("driveB", SWIMCtrl, drives[1].blk),
>> + DEFINE_PROP_END_OF_LIST(),
>> +};
>
> This is not the right way to model things. The floppy controller needs
> to expose a bus and floppy drives need to be created with a separate
> -device option.
>
> isa-fdc still has these options, but that's only for compatibility and
> their implementation is basically a wrapper around the modern qdev way.
Thank you Kevin, I will update this part.
Laurent
- [Qemu-devel] [C v2 00/10] hw/m68k: add Apple Machintosh Quadra 800 machine, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 02/10] ADB: VIA probes ADB bus when it is idle, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 04/10] hw/m68k: add video card, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 08/10] hw/m68k: add a dummy SWIM floppy controller, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 09/10] dp8393x: manage big endian bus, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 06/10] ESP: add pseudo-DMA as used by Macintosh, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 03/10] escc: introduce a selector for the register bit, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 01/10] hw/m68k: add via support, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 05/10] hw/m68k: Apple Sound Chip (ASC) emulation, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 10/10] hw/m68k: define Macintosh Quadra 800, Laurent Vivier, 2018/06/27
- [Qemu-devel] [C v2 07/10] hw/m68k: add Nubus support, Laurent Vivier, 2018/06/27