[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/23] target/openrisc: Fix mtspr shadow gprs
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/23] target/openrisc: Fix mtspr shadow gprs |
Date: |
Thu, 28 Jun 2018 11:10:19 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/28/2018 12:03 AM, Richard Henderson wrote:
> Missing break.
"when added in d89e71e873d"?
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/openrisc/sys_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
> index b284064381..2f337363ec 100644
> --- a/target/openrisc/sys_helper.c
> +++ b/target/openrisc/sys_helper.c
> @@ -98,6 +98,7 @@ void HELPER(mtspr)(CPUOpenRISCState *env,
> case TO_SPR(0, 1024) ... TO_SPR(0, 1024 + (16 * 32)): /* Shadow GPRs */
> idx = (spr - 1024);
> env->shadow_gpr[idx / 32][idx % 32] = rb;
> + break;
>
> case TO_SPR(1, 512) ... TO_SPR(1, 512+DTLB_SIZE-1): /* DTLBW0MR 0-127 */
> idx = spr - TO_SPR(1, 512);
>
- [Qemu-devel] [PATCH v3 00/23] target/openrisc improvements, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 01/23] target/openrisc: Fix mtspr shadow gprs, Richard Henderson, 2018/06/27
- Re: [Qemu-devel] [PATCH v3 01/23] target/openrisc: Fix mtspr shadow gprs,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v3 03/23] target/openrisc: Log interrupts, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 04/23] target/openrisc: Remove DISAS_JUMP & DISAS_TB_JUMP, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 05/23] target/openrisc: Use exit_tb instead of CPU_INTERRUPT_EXITTB, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 06/23] target/openrisc: Fix singlestep_enabled, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 10/23] target/openrisc: Form the spr index from tcg, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 02/23] target/openrisc: Add print_insn_or1k, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 07/23] target/openrisc: Link more translation blocks, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 08/23] target/openrisc: Split out is_user, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 12/23] target/openrisc: Remove indirect function calls for mmu, Richard Henderson, 2018/06/27
- [Qemu-devel] [PATCH v3 11/23] target/openrisc: Merge tlb allocation into CPUOpenRISCState, Richard Henderson, 2018/06/27