Re: [Qemu-devel] [PATCH 6/6] pr-manager-helper: report event on connection/disconnection

[Paolo Bonzini]

On 28/06/2018 22:24, Eric Blake wrote:
> On 06/28/2018 02:57 PM, Paolo Bonzini wrote:
>> Let management know if there were any problems communicating with
>> qemu-pr-helper.  The event is edge-triggered, and is sent every time
>> the connection status of the pr-manager-helper object changes.
> 
> Is this something that guest actions can intentionally trigger, and thus
> cause a DoS attack by flooding the management app with events faster
> than they can process?

No, unless they find a way to crash qemu-pr-helper and libvirt
immediately restarts it.  If anything libvirt could throttle the restart
of the process, or ultimately not restart it at all, but I don't think
it's necessary.

Paolo

>  If so, this event should use rate-limiting.
> 
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>   qapi/block.json          | 24 ++++++++++++++++++++++++
>>   scsi/pr-manager-helper.c | 14 ++++++++++++++
>>   2 files changed, 38 insertions(+)
>