[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option |
Date: |
Wed, 1 Aug 2018 15:11:23 +0200 |
On Wed, 1 Aug 2018 14:54:51 +0200
Cornelia Huck <address@hidden> wrote:
> On Wed, 1 Aug 2018 18:21:27 +0800
> Fam Zheng <address@hidden> wrote:
>
> > On Tue, 07/24 11:24, Cornelia Huck wrote:
> > > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> > > index a02d708239..1bd6c8b458 100644
> > > --- a/hw/s390x/css-bridge.c
> > > +++ b/hw/s390x/css-bridge.c
> > > @@ -106,7 +106,6 @@ VirtualCssBus *virtual_css_bus_init(void)
> > > /* Create bus on bridge device */
> > > bus = qbus_create(TYPE_VIRTUAL_CSS_BUS, dev, "virtual-css");
> > > cbus = VIRTUAL_CSS_BUS(bus);
> >
> > Not used now?
> >
> > Fam
>
> Indeed, we can ditch the cbus variable.
...or not :) We still need it for the return value, which is processed
in ccw_init(). We could change the return code of the function to
BusState, but I'm not sure it is worth the hassle.
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Fam Zheng, 2018/08/01
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Cornelia Huck, 2018/08/01
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option,
Cornelia Huck <=
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Cornelia Huck, 2018/08/01
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Fam Zheng, 2018/08/01
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Cornelia Huck, 2018/08/02
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Cornelia Huck, 2018/08/02
- Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option, Cornelia Huck, 2018/08/02