[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports |
|
Date: |
Wed, 1 Aug 2018 18:02:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 01/08/2018 17:59, Peter Maydell wrote:
>
> We could improve the somewhat cryptic comment:
> /*
> * 0x41 is documented as setting the output sample rate,
> * and 0x42 the input sample rate, but in fact SB16 hardware
> * seems to have only a single sample rate under the hood,
> * and some (buggy) guest programs such as FT2 will set the
> * output rate using 0x42. Compare:
> *
> http://homepages.cae.wisc.edu/~brodskye/sb16doc/sb16doc.html#SamplingRate
> */
I sometimes enjoy keeping little bits of "old-style QEMU" in these more
historical devices, but your improvement is just too good, so I'll
replace it. Thanks!
Paolo