[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 3/6 for-3.0] qcow2: Options' docume
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes |
Date: |
Fri, 03 Aug 2018 13:27:51 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Sun 29 Jul 2018 11:27:41 PM CEST, Leonid Bloch wrote:
> Signed-off-by: Leonid Bloch <address@hidden>
> ---
> docs/qcow2-cache.txt | 9 ++++++---
> qapi/block-core.json | 6 +++---
> qemu-options.hx | 15 +++++++++------
> 3 files changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt
> index 8a09a5cc5f..fd9a6911cc 100644
> --- a/docs/qcow2-cache.txt
> +++ b/docs/qcow2-cache.txt
> @@ -112,9 +112,9 @@ command-line, or the 'blockdev-add' QMP command.
>
> There are three options available, and all of them take bytes:
>
> -"l2-cache-size": maximum size of the L2 table cache
> -"refcount-cache-size": maximum size of the refcount block cache
> -"cache-size": maximum size of both caches combined
> +"l2-cache-size": maximal size of the L2 table cache
> +"refcount-cache-size": maximal size of the refcount block cache
> +"cache-size": maximal size of both caches combined
Why is 'maximum' not clear in this context?
Otherwise the patch looks good to me.
Berto
- Re: [Qemu-devel] [Qemu-block] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes,
Alberto Garcia <=