Re: [Qemu-devel] [PATCH v6 39/77] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2

[Stefan Markovic]

BPOSGE32C is introduced in DSP-R3. Shouldn't there be check_dspr3(), and 
applied here?


You're right. DSPR3 is not supported in QEMU at the moment.
Patch with DSP Revision 3 support will be included in next version of patch set.


>From the code, it turns out that the only difference between BPOSGE32 
>(supported in previous mips DSP specifications) and BPOSGE32C (nanoMIPS DSP 
>supported) is offset calculation. Is this really the only difference - from 
>the documentation?


Yes, the only difference is offset calculation.


Regards,

Stefan

________________________________
From: Aleksandar Markovic
Sent: Friday, August 3, 2018 1:20:16 PM
To: Stefan Markovic; address@hidden
Cc: address@hidden; address@hidden; address@hidden; address@hidden; 
address@hidden; Stefan Markovic; Petar Jovanovic; Paul Burton; Aleksandar Rikalo
Subject: Re: [PATCH v6 39/77] target/mips: Add emulation of DSP ASE for 
nanoMIPS - part 2

> +                case NM_BPOSGE32C:
> +                    check_dsp(ctx);
> +                    {
> +                        int32_t imm = extract32(ctx->opcode, 1, 13) |
> +                                      extract32(ctx->opcode, 0, 1) << 13;
> +
> +                        gen_compute_branch(ctx, OPC_BPOSGE32, 4, -1, -2,
> +                                           imm, 4);
> +                    }
> +                    break;


BPOSGE32C is introduced in DSP-R3. Shouldn't there be check_dspr3(), and 
applied here?

>From the code, it turns out that the only difference between BPOSGE32 
>(supported in previous mips DSP specifications) and BPOSGE32C (nanoMIPS DSP 
>supported) is offset calculation. Is this really the only difference - from 
>the documentation?

Aleksandar M.