[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct at
From: |
Yuval Shaia |
Subject: |
[Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp |
Date: |
Sun, 5 Aug 2018 18:35:07 +0300 |
Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error
where backend query_qp fails to retrieve the needed QP attributes.
Fix it by providing the attr_mask we got from driver.
Signed-off-by: Yuval Shaia <address@hidden>
Reviewed-by: Marcel Apfelbaum<address@hidden>
---
hw/rdma/vmw/pvrdma_cmd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 14255d609f..e7d6589cdc 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -524,6 +524,7 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req
*req,
struct ibv_qp_init_attr init_attr;
pr_dbg("qp_handle=%d\n", cmd->qp_handle);
+ pr_dbg("attr_mask=0x%x\n", cmd->attr_mask);
memset(rsp, 0, sizeof(*rsp));
rsp->hdr.response = cmd->hdr.response;
@@ -531,8 +532,8 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req
*req,
rsp->hdr.err = rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev,
cmd->qp_handle,
- (struct ibv_qp_attr *)&resp->attrs, -1,
- &init_attr);
+ (struct ibv_qp_attr *)&resp->attrs,
+ cmd->attr_mask, &init_attr);
pr_dbg("ret=%d\n", rsp->hdr.err);
return rsp->hdr.err;
--
2.17.1
- [Qemu-devel] [PATCH v2 00/13] Misc fixes for pvrdma device, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 02/13] hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp,
Yuval Shaia <=
- [Qemu-devel] [PATCH v2 04/13] hw/pvrdma: Clean CQE before use, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 01/13] hw/rdma: Make distinction between device init and start modes, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 05/13] hw/pvrdma: Make default pkey 0xFFFF, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 07/13] hw/rdma: Do not allocate memory for non-dma MR, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 03/13] hw/rdma: Modify debug macros, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 06/13] hw/rdma: Delete useless structure RdmaRmUserMR, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 09/13] hw/pvrdma: Cosmetic change - indent right, Yuval Shaia, 2018/08/05
- [Qemu-devel] [PATCH v2 13/13] hw/rdma: Add reference to pci_dev in backend_dev, Yuval Shaia, 2018/08/05