[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 02/23] libqtest: Clean up how we read device_del
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 02/23] libqtest: Clean up how we read device_del messages |
Date: |
Mon, 6 Aug 2018 08:53:23 +0200 |
qtest_qmp_device_del() still uses the qmp("") hack to receive a
message, even though we have qmp_receive() since commit 66e0c7b187e.
Put it to use.
Bonus: gets rid of empty format strings. A step towards compile-time
format string checking without triggering -Wformat-zero-length.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/libqtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 9cb4096639..071d7eb7b1 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -1090,7 +1090,7 @@ void qtest_qmp_device_del(const char *id)
g_assert(response1);
g_assert(!qdict_haskey(response1, "error"));
- response2 = qmp("");
+ response2 = qmp_receive();
g_assert(response2);
g_assert(!qdict_haskey(response2, "error"));
--
2.17.1
- [Qemu-devel] [PATCH v3 17/23] migration-test: Make wait_command() cope with '%', (continued)
- [Qemu-devel] [PATCH v3 17/23] migration-test: Make wait_command() cope with '%', Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 04/23] libqtest: Remove qtest_qmp_discard_response() & friends, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 23/23] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 15/23] migration-test: Make wait_command() return the "return" member, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 22/23] libqtest: Replace qtest_startf() by qtest_initf(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 20/23] migration-test: Clean up string interpolation into QMP, part 3, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 11/23] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 06/23] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 02/23] libqtest: Clean up how we read device_del messages,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 10/23] qobject: qobject_from_jsonv() is dangerous, hide it away, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 01/23] libqtest: Rename functions to send QMP messages, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 18/23] migration-test: Clean up string interpolation into QMP, part 1, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 21/23] libqtest: Enable compile-time format string checking, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 19/23] migration-test: Clean up string interpolation into QMP, part 2, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 16/23] tests: New helper qtest_qmp_receive_success(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 14/23] tests: Clean up string interpolation around qtest_qmp_device_add(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 12/23] tests: Clean up string interpolation into QMP input (simple cases), Markus Armbruster, 2018/08/06