[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v7 14/16] hw/arm/virt: Add virtio-iommu to the virt bo
From: |
Eric Auger |
Subject: |
[Qemu-devel] [RFC v7 14/16] hw/arm/virt: Add virtio-iommu to the virt board |
Date: |
Mon, 6 Aug 2018 22:14:42 +0200 |
Both the virtio-iommu device and its dedicated mmio
transport get instantiated when requested.
Signed-off-by: Eric Auger <address@hidden>
---
v6 -> v7:
- align to the smmu instantiation code
v4 -> v5:
- VirtMachineClass no_iommu added in this patch
- Use object_resolve_path_type
---
hw/arm/virt.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
include/hw/arm/virt.h | 1 +
2 files changed, 51 insertions(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 281ddcd..dd3cc71 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -29,6 +29,7 @@
*/
#include "qemu/osdep.h"
+#include "monitor/qdev.h"
#include "qapi/error.h"
#include "hw/sysbus.h"
#include "hw/arm/arm.h"
@@ -59,6 +60,7 @@
#include "qapi/visitor.h"
#include "standard-headers/linux/input.h"
#include "hw/arm/smmuv3.h"
+#include "hw/virtio/virtio-iommu.h"
#define DEFINE_VIRT_MACHINE_LATEST(major, minor, latest) \
static void virt_##major##_##minor##_class_init(ObjectClass *oc, \
@@ -141,6 +143,7 @@ static const MemMapEntry a15memmap[] = {
[VIRT_GPIO] = { 0x09030000, 0x00001000 },
[VIRT_SECURE_UART] = { 0x09040000, 0x00001000 },
[VIRT_SMMU] = { 0x09050000, 0x00020000 },
+ [VIRT_VIRTIO_IOMMU] = { 0x09070000, 0x00000200 },
[VIRT_MMIO] = { 0x0a000000, 0x00000200 },
/* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */
[VIRT_PLATFORM_BUS] = { 0x0c000000, 0x02000000 },
@@ -165,6 +168,7 @@ static const int a15irqmap[] = {
[VIRT_MMIO] = 16, /* ...to 16 + NUM_VIRTIO_TRANSPORTS - 1 */
[VIRT_GIC_V2M] = 48, /* ...to 48 + NUM_GICV2M_SPIS - 1 */
[VIRT_SMMU] = 74, /* ...to 74 + NUM_SMMU_IRQS - 1 */
+ [VIRT_VIRTIO_IOMMU] = 75,
[VIRT_PLATFORM_BUS] = 112, /* ...to 112 + PLATFORM_BUS_NUM_IRQS -1 */
};
@@ -1047,6 +1051,42 @@ static void create_smmu(const VirtMachineState *vms,
qemu_irq *pic,
g_free(node);
}
+static void create_virtio_iommu(VirtMachineState *vms, qemu_irq *pic,
+ PCIBus *bus)
+{
+ const char compat[] = "virtio,mmio";
+ int irq = vms->irqmap[VIRT_VIRTIO_IOMMU];
+ hwaddr base = vms->memmap[VIRT_VIRTIO_IOMMU].base;
+ hwaddr size = vms->memmap[VIRT_VIRTIO_IOMMU].size;
+ DeviceState *dev;
+ BusState *virtio_bus;
+ char *node;
+
+ sysbus_create_simple("virtio-mmio", base, pic[irq]);
+
+ virtio_bus = qbus_find_recursive(sysbus_get_default(), NULL, "virtio-bus");
+ dev = DEVICE(object_new("virtio-iommu-device"));
+ qdev_set_parent_bus(dev, virtio_bus);
+ object_property_set_link(OBJECT(dev), OBJECT(bus), "primary-bus",
+ &error_abort);
+ object_property_set_bool(OBJECT(dev), false, "msi_bypass", &error_fatal);
+ object_property_set_bool(OBJECT(dev), true, "realized", &error_abort);
+
+ node = g_strdup_printf("/address@hidden" PRIx64, base);
+ qemu_fdt_add_subnode(vms->fdt, node);
+ qemu_fdt_setprop(vms->fdt, node, "compatible", compat, sizeof(compat));
+ qemu_fdt_setprop_sized_cells(vms->fdt, node, "reg", 2, base, 2, size);
+
+ qemu_fdt_setprop_cells(vms->fdt, node, "interrupts",
+ GIC_FDT_IRQ_TYPE_SPI, irq, GIC_FDT_IRQ_FLAGS_EDGE_LO_HI);
+
+ qemu_fdt_setprop(vms->fdt, node, "dma-coherent", NULL, 0);
+ qemu_fdt_setprop_cell(vms->fdt, node, "#iommu-cells", 1);
+ qemu_fdt_setprop_cell(vms->fdt, node, "phandle", vms->iommu_phandle);
+ g_free(node);
+}
+
+
static void create_pcie(VirtMachineState *vms, qemu_irq *pic)
{
hwaddr base_mmio = vms->memmap[VIRT_PCIE_MMIO].base;
@@ -1167,7 +1207,16 @@ static void create_pcie(VirtMachineState *vms, qemu_irq
*pic)
if (vms->iommu) {
vms->iommu_phandle = qemu_fdt_alloc_phandle(vms->fdt);
- create_smmu(vms, pic, pci->bus);
+ switch (vms->iommu) {
+ case VIRT_IOMMU_SMMUV3:
+ create_smmu(vms, pic, pci->bus);
+ break;
+ case VIRT_IOMMU_VIRTIO:
+ create_virtio_iommu(vms, pic, pci->bus);
+ break;
+ default:
+ g_assert_not_reached();
+ }
qemu_fdt_setprop_cells(vms->fdt, nodename, "iommu-map",
0x0, vms->iommu_phandle, 0x0, 0x10000);
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 9a870cc..837c135 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -64,6 +64,7 @@ enum {
VIRT_GIC_REDIST,
VIRT_GIC_REDIST2,
VIRT_SMMU,
+ VIRT_VIRTIO_IOMMU,
VIRT_UART,
VIRT_MMIO,
VIRT_RTC,
--
2.5.5
- [Qemu-devel] [RFC v7 04/16] virtio-iommu: Add the iommu regions, (continued)
- [Qemu-devel] [RFC v7 04/16] virtio-iommu: Add the iommu regions, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 02/16] virtio-iommu: Add skeleton, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 06/16] virtio-iommu: Implement attach/detach command, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 05/16] virtio-iommu: Endpoint and domains structs and helpers, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 07/16] virtio-iommu: Implement map/unmap, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 08/16] virtio-iommu: Implement translate, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 10/16] virtio-iommu: Add an msi_bypass property, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 09/16] virtio-iommu: Implement probe request, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 11/16] virtio-iommu: Implement fault reporting, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 12/16] virtio_iommu: Handle reserved regions in translation process, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 14/16] hw/arm/virt: Add virtio-iommu to the virt board,
Eric Auger <=
- [Qemu-devel] [RFC v7 13/16] qdev: export qbus_find_recursive, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 15/16] hw/arm/virt-acpi-build: Add virtio-iommu node in IORT table, Eric Auger, 2018/08/06
- [Qemu-devel] [RFC v7 16/16] hw/arm/virt: Allow virtio-iommu instantiation, Eric Auger, 2018/08/06