[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with v
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode |
Date: |
Tue, 7 Aug 2018 15:02:49 +0200 |
Hi
On Tue, Aug 7, 2018 at 2:55 PM, Gerd Hoffmann <address@hidden> wrote:
> On Fri, Aug 03, 2018 at 05:32:35PM +0200, Marc-André Lureau wrote:
>> With vga=775 on the Linux command line a first boot of the VM running
>> Linux works fine. After a warm reboot it crashes during Linux boot.
>>
>> Before that, valgrind points out bad memory write to console
>> surface. The VGA code is not aware that virtio-gpu got a message
>> surface scanout when the display is disabled. Let's reset VGA graphic
>> mode when it is the case, so that a new display surface is created
>> when doing further VGA operations.
>
> I guess we should simply call vga_common_reset() in virtio_vga_reset()
> instead, can you try that?
>
Yes I tried, and it still fails. However I think the call is missing
and I was planning to send it for 3.1 later, since I don't think it's
RC material.
The ordering of events is not completely obvious to me, but it's still
crashing/corrupting memory after the reset occurs. The scanout get's
disable after it iirc.
--
Marc-André Lureau
- [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Marc-André Lureau, 2018/08/03
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Stefan Berger, 2018/08/03
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Peter Maydell, 2018/08/06
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Peter Maydell, 2018/08/06
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Michael S. Tsirkin, 2018/08/06
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode, Gerd Hoffmann, 2018/08/07
- Re: [Qemu-devel] [PATCH] virtio-gpu: fix crashes upon warm reboot with vga mode,
Marc-André Lureau <=