Re: [Qemu-devel] [PATCH 4/4] qga: report serial ID and device node

[Eric Blake]

On 08/07/2018 05:49 AM, Tomáš Golembiovský wrote:
> On Linux the functionality depends on libudev.
>
> Example from Linux:
>
>      {
>        "name": "dm-2",
>        "mountpoint": "/",
>        ...
>        "disk": [
>          {
>            "serial": "SAMSUNG_MZ7LN512HCHP-000L1_S1ZKNXAG822493",
>            "dev": "/dev/sda2",
>            ...
>          }
>        ],
>      }
>
> Signed-off-by: Tomáš Golembiovský <address@hidden>
> ---

> +++ b/qga/qapi-schema.json
> @@ -834,13 +834,15 @@
>   # @bus: bus id
>   # @target: target id
>   # @unit: unit id
> +# @serial: serial number

Needs a '(since 3.1)' tag.

>   #
>   # Since: 2.2
>   ##
>   { 'struct': 'GuestDiskAddress',
>     'data': {'pci-controller': 'GuestPCIAddress',
>              'bus-type': 'GuestDiskBusType',
> -           'bus': 'int', 'target': 'int', 'unit': 'int'} }
> +           'bus': 'int', 'target': 'int', 'unit': 'int',
> +           '*serial': 'str', '*dev': 'str'} }
>   
>   ##
>   # @GuestFilesystemInfo:

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org