|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v2 4/4] qga: report serial ID and device node |
Date: | Tue, 7 Aug 2018 08:52:37 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 08/07/2018 05:51 AM, Tomáš Golembiovský wrote:
On Linux the functionality depends on libudev. Example from Linux: { "name": "dm-2", "mountpoint": "/", ... "disk": [ { "serial": "SAMSUNG_MZ7LN512HCHP-000L1_S1ZKNXAG822493", "dev": "/dev/sda2", ... } ], } Signed-off-by: Tomáš Golembiovský <address@hidden> ---
+++ b/qga/commands-posix.c @@ -47,6 +47,7 @@ extern char **environ; #include <sys/socket.h> #include <net/if.h> #include <sys/statvfs.h> +#include <libudev.h>
Is libudev universally available on BSD systems and always preinstalled on Linux systems, or does this need a configure probe?
+++ b/qga/qapi-schema.json @@ -834,13 +834,15 @@ # @bus: bus id # @target: target id # @unit: unit id +# @serial: serial number
Mails crossed; you posted v2 before my v1 comment that this needs a 'since 3.1' tag.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |