Re: [Qemu-devel] [PATCH 1/4] Add MEN Chameleon Bus emulation

[Johannes Thumshirn]

On Wed, Aug 08, 2018 at 03:52:05PM +0100, Peter Maydell wrote:
> On 8 August 2018 at 15:16, Johannes Thumshirn <address@hidden> wrote:
> > The MEN Chameleon Bus (MCB) is an on-chip bus system exposing IP Cores of an
> > FPGA to a outside bus system like PCIe.
> >
> > Signed-off-by: Johannes Thumshirn <address@hidden>
> 
> 
> > --- /dev/null
> > +++ b/hw/mcb/mcb.c
> > @@ -0,0 +1,180 @@
> > +/*
> > + * QEMU MEN Chameleon Bus emulation
> > + *
> > + * Copyright (C) 2016 Johannes Thumshirn <address@hidden>
> 
> Really 2016?

Yes originally. I'll bump it to 2016 - 2018.

> 
> > + *
> > + * This code is licensed under the GNU GPL v2 or (at your opinion) any
> 
> This should say "option" -- wording is important in license
> statements :-)  You might prefer to copy-and-paste an
> existing copyright header.

This should've been a copy&paste from somehwere. Anyways I'll fix
it.

Thanks.

-- 
Johannes Thumshirn                                          Storage
address@hidden                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850