[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/4] "pc: acpi: _CST support"
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/4] "pc: acpi: _CST support" |
Date: |
Wed, 8 Aug 2018 23:20:25 +0300 |
On Wed, Aug 08, 2018 at 05:15:45PM +0200, Igor Mammedov wrote:
> It's an alternative approach to
> 1) [PATCH hack dontapply v2 0/7] Dynamic _CST generation
> which instead of dynamic AML loading uses static AML with
> dynamic values. It allows us to keep firmware blob static and
> to avoid split firmware issue (1) in case of cross version migration.
I think there's a misunderstanding. That patch only declares a couple of
states but that is just for debugging/demonstration purposes. A typical
real CPU has more states (e.g. some intel CPUs have ~10 levels).
> ABI in this case is confined to cpu hotplug IO registers
> (i.e. do it old school way, like we used to do so far).
> This way we don't have to add yet another ABI to keep dynamic
> AML code under control (1).
>
> Tested with: XPsp3 - ws2106 guests.
>
> CC: "Michael S. Tsirkin" <address@hidden>
>
>
> Igor Mammedov (3):
> acpi: add aml_create_byte_field()
> pc: acpi: add _CST support
> acpi: add support for CST update notification
>
> Michael S. Tsirkin (1):
> acpi: aml: add aml_register()
>
> include/hw/acpi/aml-build.h | 6 ++
> include/hw/acpi/cpu.h | 10 +++
> docs/specs/acpi_cpu_hotplug.txt | 21 +++++-
> hw/acpi/aml-build.c | 28 +++++++
> hw/acpi/cpu.c | 158
> +++++++++++++++++++++++++++++++++++++++-
> hw/acpi/piix4.c | 2 +
> hw/i386/acpi-build.c | 5 +-
> tests/bios-tables-test.c | 1 +
> 8 files changed, 225 insertions(+), 6 deletions(-)
>
> --
> 2.7.4
[Qemu-devel] [RFC PATCH 2/4] acpi: add aml_create_byte_field(), Igor Mammedov, 2018/08/08
[Qemu-devel] [RFC PATCH 4/4] acpi: add support for CST update notification, Igor Mammedov, 2018/08/08
Re: [Qemu-devel] [RFC PATCH 0/4] "pc: acpi: _CST support",
Michael S. Tsirkin <=