[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 05/22] check: Only test usb-xhci-nec when it
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 05/22] check: Only test usb-xhci-nec when it is compiled in |
|
Date: |
Thu, 9 Aug 2018 07:28:55 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 08/08/2018 07:02 PM, Juan Quintela wrote:
> Thomas Huth <address@hidden> wrote:
[...]
> I didn't want to go "further", but I think that we should have here is
> something like:
>
> check-qtest-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
> gcov-files-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
>
> and remove the arch specific bits. If one arch don't support it, we
> know have CONFIG_USB_XHCI bits to not _enable_ it there.
>
> What do you think?
>
> Thanks, Juan.
If "make check" passes with that change, that sounds like the right
solution to me, too.
Thomas
- Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in, (continued)
[Qemu-devel] [PATCH v2 01/22] configure: We don't want to clean configuration files, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 07/22] check: Only test ivshm when it is compiled in, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 05/22] check: Only test usb-xhci-nec when it is compiled in, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 06/22] i386-softmmu: Configuration is identical to x86_64-softmmu, Juan Quintela, 2018/08/08
[Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes, Juan Quintela, 2018/08/08