Re: [Qemu-devel] [PATCH v2 12/22] virtio: split input bits from virtio-pci

[Thomas Huth]

On 08/08/2018 01:48 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  hw/virtio/Makefile.objs      |   1 +
>  hw/virtio/virtio-input-pci.c | 136 +++++++++++++++++++++++++++++++++++
>  hw/virtio/virtio-pci.c       | 112 -----------------------------
>  3 files changed, 137 insertions(+), 112 deletions(-)
>  create mode 100644 hw/virtio/virtio-input-pci.c
> 
> diff --git a/hw/virtio/Makefile.objs b/hw/virtio/Makefile.objs
> index 685ae1d866..6819ed4e14 100644
> --- a/hw/virtio/Makefile.objs
> +++ b/hw/virtio/Makefile.objs
> @@ -12,6 +12,7 @@ obj-$(call 
> land,$(CONFIG_VIRTIO_CRYPTO),$(CONFIG_VIRTIO_PCI)) += virtio-crypto-p
>  obj-$(CONFIG_LINUX) += vhost.o vhost-backend.o vhost-user.o
>  obj-$(CONFIG_VHOST_VSOCK) += vhost-vsock.o vhost-vsock-pci.o
>  obj-$(CONFIG_VIRTIO_INPUT_HOST) += virtio-input-host-pci.o
> +obj-$(CONFIG_VIRTIO_INPUT) += virtio-input-pci.o
>  endif
>  
>  common-obj-$(call lnot,$(call land,$(CONFIG_VIRTIO),$(CONFIG_LINUX))) += 
> vhost-stub.o
> diff --git a/hw/virtio/virtio-input-pci.c b/hw/virtio/virtio-input-pci.c
> new file mode 100644
> index 0000000000..3198a505e9
> --- /dev/null
> +++ b/hw/virtio/virtio-input-pci.c
> @@ -0,0 +1,136 @@
> +/*
> + * Virtio input PCI Bindings
> + *
> + * Copyright IBM, Corp. 2007
> + * Copyright (c) 2009 CodeSourcery
> + *
> + * Authors:
> + *  Anthony Liguori   <address@hidden>
> + *  Paul Brook        <address@hidden>
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2.  See
> + * the COPYING file in the top-level directory.
> + *
> + * Contributions after 2012-01-13 are licensed under the terms of the
> + * GNU GPL, version 2 or (at your option) any later version.
> + */

virtio-input had been added by Gerd in 2015, so I think you can now
switch to the GPLv2+ text only. Apart from that, patch looks fine to me.

 Thomas