[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] hw/arm/nrf51_soc: Connect UART to nRF51
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] hw/arm/nrf51_soc: Connect UART to nRF51 SoC |
Date: |
Fri, 10 Aug 2018 07:05:45 +0100 |
On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova <address@hidden> wrote:
> @@ -70,6 +73,19 @@ static void nrf51_soc_realize(DeviceState *dev_soc, Error
> **errp)
> }
> memory_region_add_subregion(&s->container, SRAM_BASE, &s->sram);
>
> + /* UART */
> + qdev_prop_set_chr(DEVICE(&s->uart), "chardev", serial_hd(0));
> + object_property_set_bool(OBJECT(&s->uart), true, "realized", &err);
> + if (err) {
> + error_propagate(errp, err);
> + return;
Is there cleanup missing (e.g. unrealizing sub-devices or freeing resources)?
- [Qemu-devel] [PATCH v2 0/4] arm: Add nRF51 SoC UART support, Julia Suvorova, 2018/08/08
- [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Julia Suvorova, 2018/08/08
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Stefan Hajnoczi, 2018/08/10
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Julia Suvorova, 2018/08/13
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Stefan Hajnoczi, 2018/08/13
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Julia Suvorova, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART, Paolo Bonzini, 2018/08/14
[Qemu-devel] [PATCH v2 2/4] hw/arm/nrf51_soc: Connect UART to nRF51 SoC, Julia Suvorova, 2018/08/08
[Qemu-devel] [PATCH v2 3/4] tests/boot-serial-test: Add microbit board testcase, Julia Suvorova, 2018/08/08
[Qemu-devel] [PATCH v2 4/4] tests/microbit-test: Check nRF51 UART functionality, Julia Suvorova, 2018/08/08