[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0] slirp: Correct size check in m_inc()
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0] slirp: Correct size check in m_inc() |
Date: |
Fri, 10 Aug 2018 10:13:49 +0100 |
On 10 August 2018 at 10:08, Samuel Thibault <address@hidden> wrote:
> Peter Maydell, le ven. 10 août 2018 10:02:37 +0100, a ecrit:
>> (a) you should add a comment describing what 'gapsize'
>> is, ie that there may be a gap between the in-use data and the
>> start of the allocated buffer, and
>> (b) m_inc() should change its variable name to match.
>
> Right, I have done so in my tree. Do you prefer to have it pushed for
> qemu 3.0?
No, this is definitely 3.1 material (also you should
post the patch for review as its own email, please).
thanks
-- PMM
- Re: [Qemu-devel] [PATCH for-3.0] slirp: Correct size check in m_inc(), (continued)
Re: [Qemu-devel] [PATCH for-3.0] slirp: Correct size check in m_inc(), Peter Maydell, 2018/08/07
Re: [Qemu-devel] [PATCH for-3.0] slirp: Correct size check in m_inc(), Dr. David Alan Gilbert, 2018/08/09