Re: [Qemu-devel] [PATCH v2 09/22] virtio: Remove unneeded includes

[Juan Quintela]

"Michael S. Tsirkin" <address@hidden> wrote:
> On Fri, Aug 10, 2018 at 12:01:44PM +0200, Juan Quintela wrote:
>> "Michael S. Tsirkin" <address@hidden> wrote:
>> > On Fri, Aug 10, 2018 at 09:34:32AM +0200, Juan Quintela wrote:
>> >> "Michael S. Tsirkin" <address@hidden> wrote:
>> >> > On Thu, Aug 09, 2018 at 08:03:03PM +0100, Dr. David Alan Gilbert wrote:
>> >> >> * Juan Quintela (address@hidden) wrote:
>> >> >> > They are all already included in virtio_pci.h.
>> >> >
>> >> > All I see in virtio_pci.h is:
>> >> >
>> >> > #include "standard-headers/linux/types.h"
>> >> >
>> >> > Weird.
>> >> >
>> >> > BTW what's the point of this patch?  Generally it's best not to depend
>> >> > on headers including each other, it makes refactoring harder.
>> >> 
>> >> If you see the following patches, we remove blk, net, serial, scsi,
>> >> balloon and input bits from that file, so I was removing includes patch
>> >> by patch.
>> >> 
>> >> And at the end, I found that we only need that ones.
>> >> 
>> >> "virtio-pci.h" does too many things here, I could have split it also,
>> >> because the mayority of the bits are only used now inside their own
>> >> virtio-foo-pci.c.  But then, there are things that share bits,
>> >> virtio-bus-pci is used for lots of stuff, virtio-input-pci bits are used
>> >> in virtio-input-host-pci.c, etc,   So I decided to only do the direct
>> >> split.
>> >> 
>> >> And about including directly all the files that you use, and including
>> >> only the files that are extrictly needed, the normal argument is that
>> >> the less includes, the faster compiler times.
>> >> 
>> >> Later, Juan.
>> >
>> > That's reverse of the direction we have been going.
>> > Pls move includes when you split up the files.
>> 
>> Hi
>> 
>> You want this bit of virtio-pci.h into vhost-vsock-pci.h?
>
> In fact can we move it into c file?

Miss-type.  I mean the .c file.

ok, will do for the next round.

Thanks for the comments.

>> #ifdef CONFIG_VHOST_VSOCK
>> /*
>>  * vhost-vsock-pci: This extends VirtioPCIProxy.
>>  */
>> #define TYPE_VHOST_VSOCK_PCI "vhost-vsock-pci"
>> #define VHOST_VSOCK_PCI(obj) \
>>         OBJECT_CHECK(VHostVSockPCI, (obj), TYPE_VHOST_VSOCK_PCI)
>> 
>> struct VHostVSockPCI {
>>     VirtIOPCIProxy parent_obj;
>>     VHostVSock vdev;
>> };
>> #endif
>> 
>> Except for shared things (input, bus, ...) the rest are only used on
>> the file that uses them.
>> 
>> Later, Juan.
>>