[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/9] qcow2: Cosmetic changes
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/9] qcow2: Cosmetic changes |
Date: |
Fri, 10 Aug 2018 14:54:27 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 10 Aug 2018 08:26:40 AM CEST, Leonid Bloch wrote:
> Some refactoring for better readability is done here.
>
> Signed-off-by: Leonid Bloch <address@hidden>
> - *l2_cache_entry_size = qemu_opt_get_size(
> - opts, QCOW2_OPT_L2_CACHE_ENTRY_SIZE, s->cluster_size);
> + *l2_cache_entry_size = qemu_opt_get_size(opts,
> + QCOW2_OPT_L2_CACHE_ENTRY_SIZE,
> + s->cluster_size);
> - *refcount_cache_size =
> - MIN(combined_cache_size, min_refcount_cache);
> + *refcount_cache_size = MIN(combined_cache_size,
> + min_refcount_cache);
I won't oppose these changes if more people think that they improve
readability, but it seems to me that this is just a matter of taste and
there's no big difference either way.
I'm personally fine with the way the code is now, and this coding style
is used in many other parts of QEMU:
$ git grep -A 1 '.* = .*($'
$ git grep -A 1 '.* =$'
Berto
- [Qemu-devel] [PATCH v7 0/9] Take the image size into account when allocating the L2 cache, Leonid Bloch, 2018/08/10
- [Qemu-devel] [PATCH v7 1/9] qcow2: Options' documentation fixes, Leonid Bloch, 2018/08/10
- [Qemu-devel] [PATCH v7 2/9] qcow2: Cosmetic changes, Leonid Bloch, 2018/08/10
- Re: [Qemu-devel] [PATCH v7 2/9] qcow2: Cosmetic changes,
Alberto Garcia <=
- [Qemu-devel] [PATCH v7 3/9] qcow2: Make sizes more humanly readable, Leonid Bloch, 2018/08/10
- [Qemu-devel] [PATCH v7 4/9] qcow2: Avoid duplication in setting the refcount cache size, Leonid Bloch, 2018/08/10
- [Qemu-devel] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to the image size, Leonid Bloch, 2018/08/10