[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/56] check-qjson: Cover escaped characters mor
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 09/56] check-qjson: Cover escaped characters more thoroughly, part 2 |
Date: |
Fri, 10 Aug 2018 16:16:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Cover surrogates, invalid escapes, and noncharacters. This
>> demonstrates that valid surrogate pairs are misinterpreted, and
>> invalid surrogates and noncharacters aren't rejected.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/check-qjson.c | 53 ++++++++++++++++++++++++++++++++++++++-------
>> 1 file changed, 45 insertions(+), 8 deletions(-)
>>
>
>> + { "\\u12x", NULL },
>> + { "\\u123x", NULL },
>> + { "\\u12345", "\341\210\2645" },
>> + { "\\u12345", "\341\210\2645" },
>
> Why is this one duplicated?
Editing accident, fixing.
> Otherwise,
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 00/56] json: Fixes, error reporting improvements, cleanups, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 09/56] check-qjson: Cover escaped characters more thoroughly, part 2, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 02/56] check-qjson: Cover blank and lexically erroneous input, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 01/56] check-qjson: Cover multiple JSON objects in same string, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 06/56] test-qga: Clean up how we test QGA synchronization, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 14/56] check-qjson qmp-test: Cover control characters more thoroughly, Markus Armbruster, 2018/08/08