[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/3] target/riscv: call gen_goto_tb on DISAS_
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/3] target/riscv: call gen_goto_tb on DISAS_TOO_MANY |
Date: |
Fri, 10 Aug 2018 12:52:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 08/10/2018 10:39 AM, Emilio G. Cota wrote:
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
> target/riscv/translate.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/target/riscv/translate.c b/target/riscv/translate.c
> index 66a80ca772..18d7b6d147 100644
> --- a/target/riscv/translate.c
> +++ b/target/riscv/translate.c
> @@ -1868,12 +1868,7 @@ static void riscv_tr_tb_stop(DisasContextBase *dcbase,
> CPUState *cpu)
>
> switch (ctx->base.is_jmp) {
> case DISAS_TOO_MANY:
> - tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next);
> - if (ctx->base.singlestep_enabled) {
> - gen_exception_debug();
> - } else {
> - tcg_gen_exit_tb(NULL, 0);
> - }
> + gen_goto_tb(ctx, 0, ctx->base.pc_next);
> break;
Reviewed-by: Richard Henderson <address@hidden>
r~