[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] RAMBlocks and memory_region_init_ram_nomigrate |
Date: |
Mon, 13 Aug 2018 17:45:34 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
* Paolo Bonzini (address@hidden) wrote:
> On 13/08/2018 18:16, Frank Yang wrote:
> > Hi Paolo,
> >
> > I see that migration/ram.c saves RAMBlocks associated with memory
> > regions initialized with nomigrate. Is this intended?
>
> Probably the name and size of the RAMBlocks must match but the contents
> need not (but honestly I haven't looked at the code to find the answer).
> CCing the qemu mailing list (always a good idea) and a couple people
> that might know.
All the migration code should now be using RAMBLOCK_FOREACH_MIGRATABLE and
qemu_ram_is_migratable whenever it's iterating the ramblock list,
so that *shouldn't* happen these days.
Of course we could have messed it up somewhere; what are you seeing?
Dave
> Paolo
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK