[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_a
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area |
Date: |
Tue, 14 Aug 2018 15:14:35 +0300 |
Hi all.
1. bdrv_dirty_iter_next_area don't use hbitmap_next_zero and uses
inefficient loop instead. Let's improve it.
2. bdrv_dirty_iter_next_area don't handle unaligned offset and
max_offset correctly. I'm not sure that it is a real bug. But if it is,
we need these series in 3.0.
Details are in 05 commit message.
v3:
01: - change interface to start/end, and -1 as special end-marker instead of 0
- "not found" for invalid regions instead of assert
02: rebase on 01 changes
03: - fix mistake in hbitmap_iter_init arguments (mistake in
hbitmap_next_zero arguments is fixed automatically due to 01 changes)
04: new
v2:
01: - improve comment
- s/bytes/count/
- fix forgotten function call in test
- introduce orig_size field here for HBitmap,
make checking in hbitmap_next_zero more effective and safe
02: new
03: - orig_size already introduced in 01
- fix hbitmap_next_dirty_area to not return value less than
offset on unaligned requests
Vladimir Sementsov-Ogievskiy (8):
dirty-bitmap: improve bdrv_dirty_bitmap_next_zero
tests: add tests for hbitmap_next_zero with specified end parameter
dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area
tests: add tests for hbitmap_next_dirty_area
block/mirror: fix and improve do_sync_target_write
Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area"
Revert "test-hbitmap: Add non-advancing iter_next tests"
Revert "hbitmap: Add @advance param to hbitmap_iter_next()"
include/block/dirty-bitmap.h | 8 +-
include/qemu/hbitmap.h | 30 ++++++--
block/backup.c | 4 +-
block/dirty-bitmap.c | 69 +++--------------
block/mirror.c | 16 ++--
nbd/server.c | 2 +-
tests/test-hbitmap.c | 176 ++++++++++++++++++++++++++++++++++++-------
util/hbitmap.c | 73 +++++++++++++++---
8 files changed, 258 insertions(+), 120 deletions(-)
--
2.11.1
- [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v3 6/8] Revert "block/dirty-bitmap: Add bdrv_dirty_iter_next_area", Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 5/8] block/mirror: fix and improve do_sync_target_write, Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 7/8] Revert "test-hbitmap: Add non-advancing iter_next tests", Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 1/8] dirty-bitmap: improve bdrv_dirty_bitmap_next_zero, Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 8/8] Revert "hbitmap: Add @advance param to hbitmap_iter_next()", Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 4/8] tests: add tests for hbitmap_next_dirty_area, Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 3/8] dirty-bitmap: add bdrv_dirty_bitmap_next_dirty_area, Vladimir Sementsov-Ogievskiy, 2018/08/14
- [Qemu-devel] [PATCH v3 2/8] tests: add tests for hbitmap_next_zero with specified end parameter, Vladimir Sementsov-Ogievskiy, 2018/08/14
- Re: [Qemu-devel] [PATCH v3 0/8] dirty-bitmap: rewrite bdrv_dirty_iter_next_area, no-reply, 2018/08/16