[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/10] target/arm: Correct typo in HAMAIR1 regde
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 01/10] target/arm: Correct typo in HAMAIR1 regdef name |
Date: |
Tue, 14 Aug 2018 16:33:38 +0200 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
On Tue, Aug 14, 2018 at 01:42:45PM +0100, Peter Maydell wrote:
> We implement the HAMAIR1 register as RAZ/WI; we had a typo in the
> regdef, though, and were incorrectly naming it HMAIR1 (which is
> a different register which we also implement as RAZ/WI).
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Edgar E. Iglesias <address@hidden>
> ---
> target/arm/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 8b07bf214ec..2c5e02c0b1a 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -3773,7 +3773,7 @@ static const ARMCPRegInfo el3_no_el2_cp_reginfo[] = {
> .opc0 = 3, .opc1 = 4, .crn = 10, .crm = 3, .opc2 = 0,
> .access = PL2_RW, .type = ARM_CP_CONST,
> .resetvalue = 0 },
> - { .name = "HMAIR1", .state = ARM_CP_STATE_AA32,
> + { .name = "HAMAIR1", .state = ARM_CP_STATE_AA32,
> .opc1 = 4, .crn = 10, .crm = 3, .opc2 = 1,
> .access = PL2_RW, .type = ARM_CP_CONST,
> .resetvalue = 0 },
> @@ -3925,7 +3925,7 @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
> .access = PL2_RW, .type = ARM_CP_CONST,
> .resetvalue = 0 },
> /* HAMAIR1 is mapped to AMAIR_EL2[63:32] */
> - { .name = "HMAIR1", .state = ARM_CP_STATE_AA32,
> + { .name = "HAMAIR1", .state = ARM_CP_STATE_AA32,
> .opc1 = 4, .crn = 10, .crm = 3, .opc2 = 1,
> .access = PL2_RW, .type = ARM_CP_CONST,
> .resetvalue = 0 },
> --
> 2.18.0
>
- Re: [Qemu-devel] [PATCH 05/10] target/arm: Implement AArch32 HCR and HCR2, (continued)
- [Qemu-devel] [PATCH 09/10] target/arm: Implement AArch32 ERET instruction, Peter Maydell, 2018/08/14
- [Qemu-devel] [PATCH 03/10] target/arm: Implement RAZ/WI HACTLR2, Peter Maydell, 2018/08/14
- [Qemu-devel] [PATCH 01/10] target/arm: Correct typo in HAMAIR1 regdef name, Peter Maydell, 2018/08/14
- [Qemu-devel] [PATCH 10/10] target/arm: Implement support for taking exceptions to Hyp mode, Peter Maydell, 2018/08/14
- Re: [Qemu-devel] [PATCH 00/10] target/arm: Some pieces of support for 32-bit Hyp mode, Edgar E. Iglesias, 2018/08/15
- Re: [Qemu-devel] [Qemu-arm] [PATCH 00/10] target/arm: Some pieces of support for 32-bit Hyp mode, Peter Maydell, 2018/08/17