[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] synchronization profiler
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] synchronization profiler |
Date: |
Wed, 15 Aug 2018 16:30:48 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/3] synchronization profiler
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ac8f1dcaca qsp: track BQL callers directly
6c0b389867 monitor: show sync profiling info with 'info sync'
c43c6c8920 qsp: QEMU's Synchronization Profiler
=== OUTPUT BEGIN ===
Checking PATCH 1/3: qsp: QEMU's Synchronization Profiler...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#263:
new file mode 100644
ERROR: spaces required around that '*' (ctx:WxV)
#853: FILE: util/qsp.c:289:
+ void func_(type_ *obj, const char *file, unsigned line) \
^
ERROR: spaces required around that '*' (ctx:WxV)
#865: FILE: util/qsp.c:301:
+ int func_(type_ *obj, const char *file, unsigned line) \
^
ERROR: spaces required around that '-' (ctx:VxV)
#1028: FILE: util/qsp.c:464:
+ entry->time_s = e->ns * 1e-9;
^
ERROR: spaces required around that '-' (ctx:VxV)
#1073: FILE: util/qsp.c:509:
+ "", e->time_s, e->n_acqs, e->ns_avg * 1e-3);
^
total: 4 errors, 1 warnings, 841 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/3: monitor: show sync profiling info with 'info sync'...
Checking PATCH 3/3: qsp: track BQL callers directly...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, (continued)
- [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/13
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/14
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/16
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/16
Re: [Qemu-devel] [PATCH 0/3] synchronization profiler,
no-reply <=