Re: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v8 00/87] Add nanoMIPS support to QEMU

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
fac42f8865 qemu-doc: Add nanoMIPS-related items
d43d5394ec gdbstub: Add XML support for GDB for nanoMIPS
be84315d2b gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub
6e0ed49b51 linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh
77ade6242a linux-user: Add nanoMIPS linux user mode configuration support
fa3a48ee21 linux-user: Add support for nanoMIPS core files
5c4e621529 linux-user: Add support for statx() syscall for all platforms
e0b2c6b944 linux-user: Amend support for sigaction() syscall for nanoMIPS
5b77b3db32 linux-user: Add cpu_loop.c for nanoMIPS
c930d7df54 linux-user: Add support for nanoMIPS signal trampoline
84b6db80f6 linux-user: Add signal.c for nanoMIPS
7b6c630289 linux-user: Add target_elf.h header for nanoMIPS
ea4815bf2e linux-user: Add target_structs.h header for nanoMIPS
01ba7d1d83 linux-user: Add target_cpu.h header for nanoMIPS
646d28f897 linux-user: Add target_syscall.h header for nanoMIPS
1c313bc906 linux-user: Add sockbits.h header for nanoMIPS
d8fa5d7422 linux-user: Add target_fcntl.h header for nanoMIPS
4e6a108c25 linux-user: Update syscall_defs.h header for nanoMIPS
d9feca652a linux-user: Add termbits.h header for nanoMIPS
c4d510be5a linux-user: Add target_signal.h header for nanoMIPS
4b1f9d5fba linux-user: Add syscall numbers for nanoMIPS
9fca61d37b elf: Add nanoMIPS specific variations in ELF header fields
056bdea55d target/mips: Add definition of nanoMIPS I7200 CPU
a1d3456a16 mips_malta: Fix semihosting argument passing for nanoMIPS bare metal
8b1712a854 mips_malta: Add setting up GT64120 BARs to the nanoMIPS bootloader
ab8023fade mips_malta: Add basic nanoMIPS boot code for Malta board
c8029e0d74 elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS as legal for 
MIPS
d6f8520f27 elf: Don't check FCR31_NAN2008 bit for nanoMIPS
028dd85c14 elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too
aec7c34312 elf: Add EM_NANOMIPS value as a valid one for e_machine field
069fbd7e7c target/mips: Fix ERET/ERETNC behavior related to ADEL exception
e89fe52648 target/mips: Adjust set_pc() for nanoMIPS
7ac8ee6a05 target/mips: Adjust set_hflags_for_handler() for nanoMIPS
ae3a1c7255 target/mips: Adjust exception_resume_pc() for nanoMIPS
96a8b80e8f target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS
5f05596e99 target/mips: Add handling of branch delay slots for nanoMIPS
6561a9b7a3 disas: Add support for microMIPS and nanoMIPS
70c1c34c36 target/mips: Add emulation of DSP ASE for nanoMIPS - part 6
b8865ddc64 target/mips: Add emulation of DSP ASE for nanoMIPS - part 5
a8bbbc77a7 target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
7a3eea0733 target/mips: Add emulation of DSP ASE for nanoMIPS - part 3
f20d6e767c target/mips: Add emulation of DSP ASE for nanoMIPS - part 2
2cbfdb6373 target/mips: Add emulation of DSP ASE for nanoMIPS - part 1
948216d775 target/mips: Implement MT ASE support for nanoMIPS
ca66c06309 target/mips: Add emulation of nanoMIPS 32-bit branch instructions
3f523002af target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair
783994d6b8 target/mips: Add emulation of nanoMIPS 32-bit load and store 
instructions
043f78c068 target/mips: Implement emulation of nanoMIPS EXTW instruction
8d0ef85707 target/mips: Implement emulation of nanoMIPS ROTX instruction
82e7d6022d target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)
342833bc21 target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)
ab79a06b77 target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)
4157eb9c42 target/mips: Add emulation of nanoMIPS FP instructions
76a17b7be9 target/mips: Add emulation of nanoMIPS 48-bit instructions
f2f0c31e87 target/mips: Add emulation of nanoMIPS instructions MOVE.P and 
MOVE.PREV
1793b81c87 target/mips: Add emulation of some common nanoMIPS 32-bit 
instructions
9541d0f758 target/mips: Add emulation of nanoMIPS 16-bit save and restore 
instructions
77cfeb5e5b target/mips: Add emulation of nanoMIPS 16-bit logic instructions
543e827f55 target/mips: Add emulation of nanoMIPS 16-bit load and store 
instructions
d835b9de55 target/mips: Add emulation of nanoMIPS 16-bit misc instructions
801def3f9b target/mips: Add emulation of nanoMIPS 16-bit shift instructions
b63a7e6980 target/mips: Add emulation of nanoMIPS 16-bit branch instructions
a399d564c0 target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions
e689608f33 target/mips: Add nanoMIPS decoding and extraction utilities
ab249748fe target/mips: Add placeholder and invocation of decode_nanomips_opc()
60c689101d target/mips: Add nanoMIPS DSP ASE opcodes
069d6e6cc0 target/mips: Add nanoMIPS base instruction set opcodes
85c6419fcb target/mips: Add preprocessor constants for nanoMIPS
463e9f77e4 qemu-doc: Amend MIPS-related items
c7d6e91a16 linux-user: Add preprocessor availability control to some syscalls
fa22ac3c81 linux-user: Update MIPS syscall numbers up to kernel 4.18 headers
753b7ddc9f elf: Add ELF flags for MIPS machine variants
2731da1ea4 elf: Remove duplicate preprocessor constant definition
99ed97e25f target/mips: Add gen_op_addr_addi()
14f4e549a1 target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0
d41913a620 target/mips: Don't update BadVAddr register in Debug Mode
2583d95d46 target/mips: Implement CP0 Config1.WR bit functionality
e8bf0b5bb8 target/mips: Fix MT ASE instructions' availability control
2e40ec0a66 target/mips: Add support for availability control via bit MT
6cc683c8c2 target/mips: Add support for availability control via bit XNP
c6cf9dbbd6 target/mips: Add CP0 BadInstrX register
3da785ee55 target/mips: Update some CP0 registers bit definitions
d49428b302 target/mips: Fix two instances of shadow variables
b8b0dbf712 target/mips: Mark switch fallthroughs with interpretable comments
c3342491bc target/mips: Avoid case statements formulated by ranges - part 2
4969fbbd87 target/mips: Avoid case statements formulated by ranges - part 1
7d92c3cbb4 MAINTAINERS: Update target/mips maintainer's email addresses

=== OUTPUT BEGIN ===
Checking PATCH 1/87: MAINTAINERS: Update target/mips maintainer's email 
addresses...
Checking PATCH 2/87: target/mips: Avoid case statements formulated by ranges - 
part 1...
Checking PATCH 3/87: target/mips: Avoid case statements formulated by ranges - 
part 2...
Checking PATCH 4/87: target/mips: Mark switch fallthroughs with interpretable 
comments...
Checking PATCH 5/87: target/mips: Fix two instances of shadow variables...
Checking PATCH 6/87: target/mips: Update some CP0 registers bit definitions...
Checking PATCH 7/87: target/mips: Add CP0 BadInstrX register...
Checking PATCH 8/87: target/mips: Add support for availability control via bit 
XNP...
Checking PATCH 9/87: target/mips: Add support for availability control via bit 
MT...
Checking PATCH 10/87: target/mips: Fix MT ASE instructions' availability 
control...
Checking PATCH 11/87: target/mips: Implement CP0 Config1.WR bit functionality...
Checking PATCH 12/87: target/mips: Don't update BadVAddr register in Debug 
Mode...
Checking PATCH 13/87: target/mips: Check ELPA flag only in some cases of MFHC0 
and MTHC0...
Checking PATCH 14/87: target/mips: Add gen_op_addr_addi()...
Checking PATCH 15/87: elf: Remove duplicate preprocessor constant definition...
Checking PATCH 16/87: elf: Add ELF flags for MIPS machine variants...
Checking PATCH 17/87: linux-user: Update MIPS syscall numbers up to kernel 4.18 
headers...
Checking PATCH 18/87: linux-user: Add preprocessor availability control to some 
syscalls...
Checking PATCH 19/87: qemu-doc: Amend MIPS-related items...
Checking PATCH 20/87: target/mips: Add preprocessor constants for nanoMIPS...
Checking PATCH 21/87: target/mips: Add nanoMIPS base instruction set opcodes...
Checking PATCH 22/87: target/mips: Add nanoMIPS DSP ASE opcodes...
Checking PATCH 23/87: target/mips: Add placeholder and invocation of 
decode_nanomips_opc()...
Checking PATCH 24/87: target/mips: Add nanoMIPS decoding and extraction 
utilities...
Checking PATCH 25/87: target/mips: Add emulation of nanoMIPS 16-bit arithmetic 
instructions...
Checking PATCH 26/87: target/mips: Add emulation of nanoMIPS 16-bit branch 
instructions...
Checking PATCH 27/87: target/mips: Add emulation of nanoMIPS 16-bit shift 
instructions...
Checking PATCH 28/87: target/mips: Add emulation of nanoMIPS 16-bit misc 
instructions...
Checking PATCH 29/87: target/mips: Add emulation of nanoMIPS 16-bit load and 
store instructions...
Checking PATCH 30/87: target/mips: Add emulation of nanoMIPS 16-bit logic 
instructions...
Checking PATCH 31/87: target/mips: Add emulation of nanoMIPS 16-bit save and 
restore instructions...
Checking PATCH 32/87: target/mips: Add emulation of some common nanoMIPS 32-bit 
instructions...
Checking PATCH 33/87: target/mips: Add emulation of nanoMIPS instructions 
MOVE.P and MOVE.PREV...
Checking PATCH 34/87: target/mips: Add emulation of nanoMIPS 48-bit 
instructions...
Checking PATCH 35/87: target/mips: Add emulation of nanoMIPS FP instructions...
Checking PATCH 36/87: target/mips: Add emulation of misc nanoMIPS instructions 
(pool32a0)...
Checking PATCH 37/87: target/mips: Add emulation of misc nanoMIPS instructions 
(pool32axf)...
Checking PATCH 38/87: target/mips: Add emulation of misc nanoMIPS instructions 
(p_lsx)...
Checking PATCH 39/87: target/mips: Implement emulation of nanoMIPS ROTX 
instruction...
Checking PATCH 40/87: target/mips: Implement emulation of nanoMIPS EXTW 
instruction...
Checking PATCH 41/87: target/mips: Add emulation of nanoMIPS 32-bit load and 
store instructions...
Checking PATCH 42/87: target/mips: Implement emulation of nanoMIPS LLWP/SCWP 
pair...
Checking PATCH 43/87: target/mips: Add emulation of nanoMIPS 32-bit branch 
instructions...
Checking PATCH 44/87: target/mips: Implement MT ASE support for nanoMIPS...
Checking PATCH 45/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
1...
Checking PATCH 46/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
2...
Checking PATCH 47/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
3...
Checking PATCH 48/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
4...
Checking PATCH 49/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
5...
Checking PATCH 50/87: target/mips: Add emulation of DSP ASE for nanoMIPS - part 
6...
Checking PATCH 51/87: disas: Add support for microMIPS and nanoMIPS...
ERROR: externs should be avoided in .c files
#330: FILE: disas/mips.c:6074:
+int nanomips_dis(char *buf, unsigned address, unsigned short one,

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#414: 
new file mode 100644

ERROR: space required before that '*' (ctx:OxV)
#860: FILE: disas/nanomips.cpp:442:
+                if ((cond == 0) || (this->*cond)(op_code)) {
                                           ^

ERROR: space required before that '*' (ctx:OxV)
#888: FILE: disas/nanomips.cpp:470:
+                            dis = (this->*dis_fn)(op_code);
                                          ^

ERROR: space prohibited between function name and open parenthesis '('
#17393: FILE: include/disas/bfd.h:390:
+int print_insn_micromips        (bfd_vma, disassemble_info*);

total: 4 errors, 1 warnings, 17374 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 52/87: target/mips: Add handling of branch delay slots for 
nanoMIPS...
Checking PATCH 53/87: target/mips: Add updating BadInstr, BadInstrP, BadInstrX 
for nanoMIPS...
Checking PATCH 54/87: target/mips: Adjust exception_resume_pc() for nanoMIPS...
Checking PATCH 55/87: target/mips: Adjust set_hflags_for_handler() for 
nanoMIPS...
Checking PATCH 56/87: target/mips: Adjust set_pc() for nanoMIPS...
Checking PATCH 57/87: target/mips: Fix ERET/ERETNC behavior related to ADEL 
exception...
Checking PATCH 58/87: elf: Add EM_NANOMIPS value as a valid one for e_machine 
field...
Checking PATCH 59/87: elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS 
too...
Checking PATCH 60/87: elf: Don't check FCR31_NAN2008 bit for nanoMIPS...
Checking PATCH 61/87: elf: On elf loading, treat both EM_MIPS and EM_NANOMIPS 
as legal for MIPS...
Checking PATCH 62/87: mips_malta: Add basic nanoMIPS boot code for Malta 
board...
Checking PATCH 63/87: mips_malta: Add setting up GT64120 BARs to the nanoMIPS 
bootloader...
Checking PATCH 64/87: mips_malta: Fix semihosting argument passing for nanoMIPS 
bare metal...
Checking PATCH 65/87: target/mips: Add definition of nanoMIPS I7200 CPU...
Checking PATCH 66/87: elf: Add nanoMIPS specific variations in ELF header 
fields...
Checking PATCH 67/87: linux-user: Add syscall numbers for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 275 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 68/87: linux-user: Add target_signal.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 69/87: linux-user: Add termbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 70/87: linux-user: Update syscall_defs.h header for nanoMIPS...
Checking PATCH 71/87: linux-user: Add target_fcntl.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 72/87: linux-user: Add sockbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 73/87: linux-user: Add target_syscall.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 74/87: linux-user: Add target_cpu.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 75/87: linux-user: Add target_structs.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 76/87: linux-user: Add target_elf.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 77/87: linux-user: Add signal.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#113: 
new file mode 100644

total: 0 errors, 1 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 78/87: linux-user: Add support for nanoMIPS signal trampoline...
Checking PATCH 79/87: linux-user: Add cpu_loop.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 33 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 80/87: linux-user: Amend support for sigaction() syscall for 
nanoMIPS...
Checking PATCH 81/87: linux-user: Add support for statx() syscall for all 
platforms...
WARNING: architecture specific defines should be avoided
#45: FILE: linux-user/syscall.c:10040:
+#if defined(__NR_statx)

total: 0 errors, 1 warnings, 175 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 82/87: linux-user: Add support for nanoMIPS core files...
Checking PATCH 83/87: linux-user: Add nanoMIPS linux user mode configuration 
support...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 84/87: linux-user: Add nanoMIPS support in 
scripts/qemu-binfmt-conf.sh...
WARNING: line over 80 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:79:
+nanomips_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9\x00'

ERROR: line over 90 characters
#31: FILE: scripts/qemu-binfmt-conf.sh:80:
+nanomips_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

WARNING: line over 80 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:83:
+nanomipseb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9'

ERROR: line over 90 characters
#35: FILE: scripts/qemu-binfmt-conf.sh:84:
+nanomipseb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

total: 2 errors, 2 warnings, 34 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 85/87: gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS 
gdbstub...
Checking PATCH 86/87: gdbstub: Add XML support for GDB for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 157 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 87/87: qemu-doc: Add nanoMIPS-related items...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden