[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] sh4: fix use_icount with linux-user
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2] sh4: fix use_icount with linux-user |
Date: |
Thu, 16 Aug 2018 20:58:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
Le 11/08/2018 à 17:26, Richard Henderson a écrit :
> On 08/11/2018 01:23 AM, Laurent Vivier wrote:
>> This fixes java in a linux-user chroot:
>> $ java --version
>> qemu-sh4: .../accel/tcg/cpu-exec.c:634: cpu_loop_exec_tb: Assertion
>> `use_icount' failed.
>> qemu: uncaught target signal 6 (Aborted) - core dumped
>> Aborted (core dumped)
>>
>> In gen_conditional_jump() in the GUSA_EXCLUSIVE part, we must reset
>> base.is_jmp to DISAS_NEXT after the gen_goto_tb() as it is done in
>> gen_delayed_conditional_jump() after the gen_jump().
>>
>> Bug: https://bugs.launchpad.net/qemu/+bug/1768246
>> Fixes: 4834871bc95b67343248100e2a75ae0d287bc08b
>> ("target/sh4: Convert to DisasJumpType")
>> Reported-by: John Paul Adrian Glaubitz <address@hidden>
>> Signed-off-by: Laurent Vivier <address@hidden>
>> ---
>>
>> Notes:
>> v2:
>> don't revert the part of the original patch,
>> but fixes the state problem in gen_conditional_jump()
>
> Reviewed-by: Richard Henderson <address@hidden>
Aurélien,
do you agree if I push this patch through a linux-user pull request?
Thanks,
Laurent