[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API |
Date: |
Fri, 17 Aug 2018 15:17:49 +0200 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
On Fri, Aug 17, 2018 at 12:46:16PM +0100, Peter Maydell wrote:
> Now that support has hit master for direct execution from
> arbitrary MMIO regions, we can remove the MMIO request_ptr
> API, which required special case support in each device that
> wanted to handle it, and also had bad race conditions that
> resulted in crashes if you tried to use it heavily.
>
> This API was only ever used in one device in the source
> tree, the Xilinx SPIPS. These three patches remove the
> now-unneeded code from the Xilinx device and then the
> core memory subsystem code.
Reviewed-by: Edgar E. Iglesias <address@hidden>
>
> thanks
> -- PMM
>
> Peter Maydell (3):
> hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code
> memory: Remove MMIO request_ptr APIs
> hw/misc: Remove mmio_interface device
>
> hw/misc/Makefile.objs | 1 -
> include/exec/memory.h | 35 --------
> include/hw/misc/mmio_interface.h | 49 -----------
> hw/misc/mmio_interface.c | 135 -------------------------------
> hw/ssi/xilinx_spips.c | 46 -----------
> memory.c | 110 -------------------------
> 6 files changed, 376 deletions(-)
> delete mode 100644 include/hw/misc/mmio_interface.h
> delete mode 100644 hw/misc/mmio_interface.c
>
> --
> 2.18.0
>